Clean up the codebase according to new rules in clang-tidy 18 (#114) #253

	# Continuous Integration tests
	name: MacOS

	on:
	# Triggers the workflow on push or pull request events but only for the main branch
	push:
	branches: [main]
	pull_request:
	branches: [main]

	# Ensure that only one instance of the workflow is run at a time for each branch/tag.
	# Jobs currently running on the branch/tag will be cancelled when new commits are pushed.
	# See https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#concurrency.
	concurrency:
	# `github.workflow` is the workflow name, `github.ref` is the current branch/tag identifier
	group: ${{ format('{0}:{1}', github.workflow, github.ref) }}
	cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

	jobs:
	macos-latest:
	name: MacOS Latest
	runs-on: macos-latest

	steps:
	- name: Checkout Code
	uses: actions/checkout@v4

	- name: Setup CCache
	uses: hendrikmuhs/[email protected]
	with:
	key: ${{ github.job }}
	max-size: 100M

	- name: Install CMake
	uses: lukka/get-cmake@latest
	with:
	cmakeVersion: 3.27.1
	ninjaVersion: 1.11.1

	- name: Configure CMake
	env:
	CXXFLAGS: -DNUCLEAR_TEST_TIME_UNIT_DEN=10
	run: \|
	cmake -E make_directory build
	cmake -S . -B build \
	-GNinja \
	-DCMAKE_C_COMPILER_LAUNCHER=ccache \
	-DCMAKE_CXX_COMPILER_LAUNCHER=ccache \
	-DBUILD_TESTS=ON \
	-DCMAKE_BUILD_TYPE=Release \
	-DCI_BUILD=ON \
	-DENABLE_CLANG_TIDY=OFF

	- name: Build
	timeout-minutes: 30
	run: cmake --build build --config Release

	- name: CCache Stats
	run: ccache --show-stats

	- name: Test
	timeout-minutes: 3
	working-directory: build/tests
	run: ctest --output-on-failure

Provide feedback