Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eggs common tag #3861

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from
+15 −0
Open

Add eggs common tag #3861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...a/net/fabricmc/fabric/impl/tag/convention/datagen/generators/EnglishTagLangGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,7 @@ public void generateTranslations(RegistryWrapper.WrapperLookup registryLookup, T
translationBuilder.add(ConventionalItemTags.ROPES, "Ropes");
translationBuilder.add(ConventionalItemTags.CHAINS, "Chains");
translationBuilder.add(ConventionalItemTags.HIDDEN_FROM_RECIPE_VIEWERS, "Hidden From Recipe Viewers");
translationBuilder.add(ConventionalItemTags.EGGS, "Eggs");

// Enchantments
translationBuilder.add(ConventionalEnchantmentTags.INCREASE_BLOCK_DROPS, "Increases Block Drops");
Expand Down
3 changes: 3 additions & 0 deletions ...gen/java/net/fabricmc/fabric/impl/tag/convention/datagen/generators/ItemTagGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,9 @@ private void generateOtherTags() {
.add(Items.CHAIN);

getOrCreateTagBuilder(ConventionalItemTags.HIDDEN_FROM_RECIPE_VIEWERS); // Generate tag so others can see it exists through JSON.

getOrCreateTagBuilder(ConventionalItemTags.EGGS)
.add(Items.EGG);
}

private void generateDyedTags() {
Expand Down
1 change: 1 addition & 0 deletions ...nvention-tags-v2/src/generated/resources/assets/fabric-convention-tags-v2/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@
"tag.item.c.dyes.red": "Red Dyes",
"tag.item.c.dyes.white": "White Dyes",
"tag.item.c.dyes.yellow": "Yellow Dyes",
"tag.item.c.eggs": "Eggs",
"tag.item.c.enchantables": "Enchantables",
"tag.item.c.foods": "Foods",
"tag.item.c.foods.berries": "Berries",
Expand Down
5 changes: 5 additions & 0 deletions fabric-convention-tags-v2/src/generated/resources/data/c/tags/item/eggs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"values": [
"minecraft:egg"
]
}
5 changes: 5 additions & 0 deletions ...tags-v2/src/main/java/net/fabricmc/fabric/api/tag/convention/v2/ConventionalItemTags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,11 @@ private ConventionalItemTags() {
*/
public static final TagKey<Item> HIDDEN_FROM_RECIPE_VIEWERS = register("hidden_from_recipe_viewers");

/**
* For eggs that are like chicken eggs, used for recipes.
*/
public static final TagKey<Item> EGGS = register("eggs");

/**
* This tag is redundant. Please use {@link ConventionalItemTags#STORAGE_BLOCKS} tag instead.
*/
Expand Down
Loading