Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eggs common tag #3861

Open
wants to merge 1 commit into
base: 1.21
Choose a base branch
from

Conversation

ThatGravyBoat
Copy link

This adds the eggs tag which is present on neoforge but is not on fabric, this is a very useful tags as it allows use of common eggs between platforms especially for recipes, several mods add their own egg to this tag but vanillas chicken egg is not in there by default unless a mod adds it which causes issues or is just slightly annoying that if you want to use it you either have to have an or for the tag and the vanilla item or you have to add the vanilla item yourself to the tag.

@haykam821
Copy link
Contributor

haykam821 commented Jun 16, 2024

Should a tag of eggs that doesn't contain sniffer, turtle, or dragon eggs (and arguably frogspawn, but maybe not spawn eggs) be named c:eggs?

@ThatGravyBoat
Copy link
Author

Should a tag of eggs that doesn't contain sniffer, turtle, or dragon eggs (and arguably frogspawn, but maybe not spawn eggs) be named c:eggs?

I would say yes, as I said this is already a tag used by the community in several mods, making the tag either include the other eggs would cause a discrepancy between existing mods that have already standardized using only the chicken egg in this tag, from all public mods available on GitHub not a single one adds the dragon, sniffer, or turtle egg, and if it were to be changed to another name it would not put it inline with the existing tag that didn't seem to be added to fabric during the tag pr.

@haykam821
Copy link
Contributor

I think this tag should be named something along the lines of c:baking_eggs instead of adding a new tag that is wrong.

@modmuss50
Copy link
Member

Yes, I agree with @haykam821 here, if its known to be a bad name then we shouldn't add it.

@modmuss50 modmuss50 added small change priority:low Low priority PRs that don't immediately need to be resolved labels Jun 17, 2024
@ThatGravyBoat
Copy link
Author

Yes, I agree with @haykam821 here, if its known to be a bad name then we shouldn't add it.

I understand, I do think the c:baked_eggs does not convey effectively what the tag is commonly and already used by many for, I think a better name then could be c:food_ingredients/eggs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority PRs that don't immediately need to be resolved small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants