Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SRandom::randStr() not require a reference #1786

Merged
merged 1 commit into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libstuff/SRandom.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ uint64_t SRandom::rand64() {
return _distribution64(_generator);
}

string SRandom::randStr(uint& length) {
string SRandom::randStr(uint length) {
string str = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
string newstr;
int pos;
while(newstr.size() != length) {
while (newstr.size() != length) {
pos = (rand64() % (str.size() - 1));
newstr += str.substr(pos,1);
newstr += str.substr(pos, 1);
}
return newstr;
}
2 changes: 1 addition & 1 deletion libstuff/SRandom.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class SRandom {
public:
static uint64_t rand64();
static uint64_t limitedRand64(uint64_t min, uint64_t max);
static string randStr(uint& length);
static string randStr(uint length);

private:
static mt19937_64 _generator;
Expand Down