Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SRandom::randStr() not require a reference #1786

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

coleaeason
Copy link
Contributor

@tylerkaraszewski This updates SRandom::randStr() to not require a reference. I'm not sure why we originally implemented it this way (we being me). We have a bunch of code in Auth like this:

int64_t size = 123;
string rand = SRandom::randStr(size);

instead of being able to just do this:

string rand = SRandom::randStr(123):

Fixed Issues

Confusing code

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@coleaeason coleaeason self-assigned this Jun 25, 2024
@tylerkaraszewski tylerkaraszewski merged commit f636d81 into main Jun 25, 2024
1 check passed
@tylerkaraszewski tylerkaraszewski deleted the cole_srandom branch June 25, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants