Make SRandom::randStr() not require a reference #1786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tylerkaraszewski This updates
SRandom::randStr()
to not require a reference. I'm not sure why we originally implemented it this way (we being me). We have a bunch of code in Auth like this:instead of being able to just do this:
string rand = SRandom::randStr(123):
Fixed Issues
Confusing code
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes