[HybridApp] Bring back Travel to HybridApp #51327

mateuuszzzzz · 2024-10-23T11:53:27Z

Details

This PR was reverted before. Current PR fixes the following issues:

Fix android parsing issue (We don't have issue created for this one)
Fix android blocked on travel page issue
Fix non-HybridApp onboarding issue

OldDot PR: https://github.com/Expensify/Mobile-Expensify/pull/13245

iOS issue is not in the scope of this PR since it was not introduced by Travel PR.

Fixed Issues

$ #47734
PROPOSAL:

All tests/offline tests/QA steps are the same as in this PR: #49602

Tests

Offline tests

QA Steps

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

See https://github.com/Expensify/Mobile-Expensify/pull/13234

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…Dot travel page"" This reverts commit 3d342ee.

mateuuszzzzz · 2024-10-28T15:45:59Z

One visual change on OldDot side. I changed Trips to Travel

mateuuszzzzz · 2024-10-28T16:11:24Z

One performance test has failed. I'm not sure if we can guarantee smaller number of renders in this case, but I will investigate it tomorrow

melvin-bot · 2024-10-28T16:11:39Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2024-10-29T00:49:24Z

@situchan as you reviewed the original PR for this, can you review this one today please?

situchan

perf tests failing

mateuuszzzzz · 2024-10-29T08:53:58Z

perf tests failing

@situchan done

mateuuszzzzz · 2024-10-29T10:03:15Z

I noticed small issue. Sometimes during first transition to NewDot via Travel button (after fresh install) we can see FullPageNotFoundView. It happens, because ONYXKEYS.BETAS are not loaded so NewDot intentionally hides travel page. Once betas are loaded we see travel page.

Btw this might turn out to be non-trivial. We can simply wait for keys to be loaded. However, if the user is offline, the BootSplash will hang indefinitely. We can additionally check if the user is offline to skip waiting for the keys, but then user will see FullPageNotFoundView (only after fresh install).

Slow connection would also increase transition time significantly.

Third approach: load betas on OldDot side. I'm not sure if this is possible with OldDot API. I think we might experience similar issues with copilot beta on HybridApp

Is it reasonable approach? cc: @AndrewGable @trjExpensify

Moved this discussion to slack: https://swmansion.slack.com/archives/C07HPDRELLD/p1730199889493489?thread_ts=1730160906.750479&cid=C07HPDRELLD

AndrewGable · 2024-10-29T16:45:12Z

Oh great find, I think we should load the betas on the OldApp side of things and not show the "new UI" unless they are on the beta.

situchan · 2024-10-29T20:38:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-10-30.at.10.45.02.PM.mov

MacOS: Desktop

situchan · 2024-10-29T20:41:02Z

iOS issue is not in the scope of this PR since it was not introduced by Travel PR.

@mateuuszzzzz are you sure? Please check #51139 (comment).
I am not sure any other PR in deploy checklist caused this crash during that deploy cycle.

situchan · 2024-10-29T20:43:17Z

Please also test #51115 in HybridApp.

mateuuszzzzz · 2024-10-30T08:11:12Z

iOS issue is not in the scope of this PR since it was not introduced by Travel PR.

@mateuuszzzzz are you sure? Please check #51139 (comment). I am not sure any other PR in deploy checklist caused this crash during that deploy cycle.

I observed the same crashes in the Crashlytics console that were not caused by the Travel PR, as they occurred in versions where Travel hadn’t been merged or had already been reverted. Here is more details #47734 (comment)

mateuuszzzzz · 2024-10-30T08:14:50Z

Oh great find, I think we should load the betas on the OldApp side of things and not show the "new UI" unless they are on the beta.

I'm going to investigate how we can use those betas on OldApp side of things and introduce modifications to both of my PRs

AndrewGable · 2024-10-30T14:43:03Z

Check app/libs/permissions.js

situchan

Confirmed no regression on non-hybrid app.

Please resolve conflict and perform regression test #51115 on hybrid app

AndrewGable · 2024-10-31T17:36:32Z

I think this is held on figuring out beta permissions

mateuuszzzzz · 2024-11-05T10:03:03Z

Please also test #51115 in HybridApp.

I confirmed that on HybridApp onboarding flow works correctly for all scenarios listed in useOnboardingFlow hook

mateuuszzzzz · 2024-11-05T10:06:21Z

@situchan I think you can take a look again once tests will pass. I added betas check on OldDot side as well so we don't need to rely on FullPageNotFoundView in case of MyTravelPage on HybridApp.

situchan · 2024-11-05T10:08:54Z

Code looks good. I am not able to test Hybrid app. Should be internal testing

mateuuszzzzz · 2024-11-05T10:11:45Z

Code looks good. I am not able to test Hybrid app. Should be internal testing

I tested HybridApp on my side with new betas check in mind and It works as expected

OSBotify · 2024-11-05T21:54:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2024-11-06T00:20:35Z

@situchan could you help with QA steps in the linked issue? Should this be tested from OD app?

github-actions · 2024-11-06T00:36:52Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-07T12:41:54Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

mateuuszzzzz added 4 commits October 23, 2024 11:40

Revert "Revert "[HybridApp] Allow classic experience users to use New…

4a721c4

…Dot travel page"" This reverts commit 3d342ee.

Fix bug when user cannot return from Travel page

a42aadc

Remove parsing error

116a72b

Fix onboarding on non-HybridApp platforms

3bf0693

mateuuszzzzz mentioned this pull request Oct 28, 2024

[HOLD for payment 2024-11-14] [HybridApp] Open New Expensify /travel when clicking on the HybridApp Trips tab #47734

Closed

mateuuszzzzz added 2 commits October 28, 2024 14:07

Merge branch 'main' into bring-back-travel-to-hybridapp

88942e0

Refactor useOnboardingFlow hook

00f3de8

mateuuszzzzz marked this pull request as ready for review October 28, 2024 16:11

mateuuszzzzz requested a review from a team as a code owner October 28, 2024 16:11

melvin-bot bot requested review from rayane-djouah and removed request for a team October 28, 2024 16:11

situchan reviewed Oct 29, 2024

View reviewed changes

Change dependency array

0baafa0

mateuuszzzzz requested a review from situchan October 29, 2024 08:53

trjExpensify removed the request for review from rayane-djouah October 29, 2024 11:11

situchan approved these changes Oct 31, 2024

View reviewed changes

melvin-bot bot requested a review from AndrewGable October 31, 2024 05:49

AndrewGable changed the title ~~[HybridApp] Bring back Travel to HybridApp~~ [hold][HybridApp] Bring back Travel to HybridApp Oct 31, 2024

Do not use FullPageNotFoundView for Travel on HybridApp

2b38dc3

Merge branch 'main' into bring-back-travel-to-hybridapp

1f0017a

Do not use FullPageNotFoundView on HybridApp on TravelTerms

971a611

AndrewGable changed the title ~~[hold][HybridApp] Bring back Travel to HybridApp~~ [HybridApp] Bring back Travel to HybridApp Nov 5, 2024

AndrewGable approved these changes Nov 5, 2024

View reviewed changes

AndrewGable merged commit 0deafe2 into Expensify:main Nov 5, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HybridApp] Bring back Travel to HybridApp #51327

[HybridApp] Bring back Travel to HybridApp #51327

mateuuszzzzz commented Oct 23, 2024 •

edited

Loading

mateuuszzzzz commented Oct 28, 2024 •

edited

Loading

mateuuszzzzz commented Oct 28, 2024

melvin-bot bot commented Oct 28, 2024

trjExpensify commented Oct 29, 2024

situchan left a comment

mateuuszzzzz commented Oct 29, 2024

mateuuszzzzz commented Oct 29, 2024 •

edited

Loading

AndrewGable commented Oct 29, 2024

situchan commented Oct 29, 2024 •

edited

Loading

situchan commented Oct 29, 2024 •

edited

Loading

situchan commented Oct 29, 2024

mateuuszzzzz commented Oct 30, 2024 •

edited

Loading

mateuuszzzzz commented Oct 30, 2024

AndrewGable commented Oct 30, 2024

situchan left a comment

AndrewGable commented Oct 31, 2024

mateuuszzzzz commented Nov 5, 2024

mateuuszzzzz commented Nov 5, 2024

situchan commented Nov 5, 2024

mateuuszzzzz commented Nov 5, 2024

OSBotify commented Nov 5, 2024

kavimuru commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

[HybridApp] Bring back Travel to HybridApp #51327

[HybridApp] Bring back Travel to HybridApp #51327

Conversation

mateuuszzzzz commented Oct 23, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mateuuszzzzz commented Oct 28, 2024 • edited Loading

mateuuszzzzz commented Oct 28, 2024

melvin-bot bot commented Oct 28, 2024

trjExpensify commented Oct 29, 2024

situchan left a comment

Choose a reason for hiding this comment

mateuuszzzzz commented Oct 29, 2024

mateuuszzzzz commented Oct 29, 2024 • edited Loading

AndrewGable commented Oct 29, 2024

situchan commented Oct 29, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan commented Oct 29, 2024 • edited Loading

situchan commented Oct 29, 2024

mateuuszzzzz commented Oct 30, 2024 • edited Loading

mateuuszzzzz commented Oct 30, 2024

AndrewGable commented Oct 30, 2024

situchan left a comment

Choose a reason for hiding this comment

AndrewGable commented Oct 31, 2024

mateuuszzzzz commented Nov 5, 2024

mateuuszzzzz commented Nov 5, 2024

situchan commented Nov 5, 2024

mateuuszzzzz commented Nov 5, 2024

OSBotify commented Nov 5, 2024

kavimuru commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

mateuuszzzzz commented Oct 23, 2024 •

edited

Loading

mateuuszzzzz commented Oct 28, 2024 •

edited

Loading

mateuuszzzzz commented Oct 29, 2024 •

edited

Loading

situchan commented Oct 29, 2024 •

edited

Loading

situchan commented Oct 29, 2024 •

edited

Loading

mateuuszzzzz commented Oct 30, 2024 •

edited

Loading