Deploy Checklist: New Expensify 2024-11-05

[github-actions]

Release Version: 9.0.58-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Feature: add loading indicator when ReconnectApp is running #48772
• migrate from withOnyx HOC to the useOnyx hook #50443
• build optimistic change field action #50710
• fix: incorrect lhn report name when partially pay held report #50762
• [Self-guided tours][V3] Add tour link to FAB #51136
• [Self-guided tours][V2] Add tour links to onboarding tasks #51153
• fix: app crash when opening split view #51244
• Fix "same search query appears twice in Recent searches" #51314
• Fix current selection for web TextInputWithCurrencySymbol #51325
• [HybridApp] Bring back Travel to HybridApp #51327
• Debug mode for Inbox tab GBR doesn't handle multi-policy #51425
• [Snyk] Upgrade electron-updater from 6.3.8 to 6.3.9 #51536
• Wrong validation message when sending invoice #51545
• fix: App crashes when opening user profile #51548
• [Custom feeds] Feed details explanation links #51575
• Copilot error refactor - display error from server #51588
• Don't show join thread for task action #51627
• Fix: Open Room Mention in RHP from Search  #51666
• [Custom feeds] Clean up for the wallet and workspace member page #51671
• [No QA] fix: show newly added feed as last selected feed #51719
• Fix: Distance tab is gray and not highlighted in green when swiping to Distance  #51762
• Replace checkmark icon for enabling and close icon for disabling #51779
• [No QA]: Add test to reauthenticate offline user #51805
• Revert "Add regex to TextInput" #51849
• Android onHostResume resume frame callback #51903
• fix: Remove the redundant + New workspace button from the Workspaces page when no workspaces exist. #51904
• Fix offline indicator overlaps with navbar when keyboard is closing #51922
• fix dismissing modal #51925
• fix: QAB - Error shows up when submitting split distance expense via split manual shortcut in QAB. #51931
• Fix for edit amount page flickering #51935
• fix distance and rate show pending on just track it route #51939
• fix: wrap the page in FullPageOfflineBlockingView #51947
• Workspace Feed - Limit card name #51948
• [Workspace feed] Add selected employee name to the subtitle of assign card flow #51950
• Workspace Feed - remove capitalization for card type #51952
• Update Reimburse-Reports.md #51967
• Remove Copilot Beta #51971
• Update en.ts #51990
• Reset completedTaskReportActionID to undefined so it's not passed to the backend when not used #51992
• [NoQA] Use boolean operator to fix lint #51999
• Workspace Feed - update text position and stylings #52005
• Patch 220402 #52006
• [Workspace Feeds] Update "From the beginning" option date display #52015
• Bump reanimated and fix LoadingBar error #52051
• [No QA] Add more info for filling out the QA tests in the PR template #52055
• [No QA]Fix web staging sourcemap file name #52063
• [NO QA] Update Use-your-Expensify-Card.md #52064
• Whitelist QA email for Fullstory on staging environments #52065
• [NO QA] Create Expensify-Lounge.md #52066
• [NO QA] Update redirects.csv #52067
• [CP Staging] Revert "Feature: add loading indicator when ReconnectApp is running" #52112
• [CP STAGING] fix: Bank account - Website in upper-case letters is accepted despite validation error. #52155

Deploy Blockers:

• [HOLD for payment 2024-11-20] Tour link - Tour link does not disappear after it is clicked for Expensifail accounts #52095
• [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error #52096
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Invoices - Company website field does not show the website when it is auto populated #52097
• [hold] Web - Concierge - Take a 2-minute tour task not autocomplete after finishing tour #52098
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense #52099
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Android - Finder - App crashes when opening chat via finder and tapping back arrow #52101
• Debug - "Clicking on View button leads to not here page when opening invalid URL #52104
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Android -Copilot-App crashes when adding a copilot #52106
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Android - Expense - App crashes when switching between Manual and Distance tab multiple times #52108
• [HOLD for payment 2024-11-18] [$250] Android - Chat - App crashes when sending an emoji and trying to edit  #52110
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Android - Distance expense - App freezes and crashes when adding or editing viewpoints #52111
• [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] Android - Workspace - App freezes then crashes when inviting a member to a workspace #52113
• Public room - Tour link appears for anonymous user in public room #52115
• Android - NetSuite - App freezes then crashes when connecting to NetSuite #52122
• [$250] Copilot - Account switcher disappears in settings page when forcekill & reopen app #52126
• [$250] Tags - State field is not auto selected when there is only one tag #52137

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.58-0 🚀

[izarutskaya]

Regression is at 63 % completed

PRs:
#50710 - Failing with #50020
#51153 - Found KI #52098
#51931 - KI #50694
#51971 - KI #51042

Blockers:
#52095
#52096
#52097
#52098

[lakchote]

Demoted #52098 for this reason.

[Julesssss]

Demoting #52097

[Julesssss]

Checking off #52104

[carlosmiceli]

This was fixed by the CP: #52108

[kavimuru]

Regression is 7% left

Unchecked PRs:
#50710 - Failing with original KI #50710 (comment)
#51153 iOS validation is pending
#51244 iOS validation is pending
#51314 iOS validation is pending
#51327 iOS validation is pending
#51425 android and iOS validation are pending
#51575 iOS validation is pending
#51588 iOS validation is pending, failing with #52118 in desktop and android
#51779 iOS validation is pending
#51849 failing with #52099
#51925 iOS validation is pending
#51931 failing with original KI in mweb #51931 (comment)
#51947 iOS validation is pending
#51971 iOS validation pending

The following PRs related to company card feed were internally verified by @joekaufmanexpensify, I am checking it off.
https://applause-ts.slack.com/archives/C9YU7BX5M/p1730897126117409
#51671
#51948
#51950
#51952
#52015

#51136 checked it off as there was no QA steps

[rlinoz]

Checking off
#52099
#52101
#52106
#52110
#52111
#52113

Per https://expensify.slack.com/archives/C9YU7BX5M/p1730918481651709?thread_ts=1730910115.500509&cid=C9YU7BX5M

[srikarparsi]

Checking off #52122 as it was also fixed by the revert

[kavimuru]

Regression is completed:
Unchecked PRs:
#50710 - Failing with original KI #50710 (comment)
#51425 failing with #52104
#51588 failing with #52118 and #52106
#51849 failing with #52099
#51931 failing with original KI in mweb #51931 (comment)

[Julesssss]

Checking off #52137

[Julesssss]

#50710 - Failing with original KI #50710 (comment)

Issue was deemed not to be a blocker

#51425 failing with #52104

We closed as it is being fixed elsewhere

#51588 failing with #52118 and #52106

Fixed, not a blocker

#51849 failing with #52099

Fixed

#51931 failing with original KI in mweb #51931 (comment)

Issue is not direct cause, being fixed elsewhere.

[Julesssss]

• [HOLD for payment 2024-11-14] [$250] Bank account - Website in upper-case letters is accepted despite validation error #52096 fixed by [CP STAGING] fix: Bank account - Website in upper-case letters is accepted despite validation error. #52155 (comment)
• Checking off this revert CP: [CP Staging] Revert "Feature: add loading indicator when ReconnectApp is running" #52112
• Remaining failed test not deemed to be blocking: Copilot-No error message after entering the wrong code multiple times #52118

[Julesssss]

• Firebase crashes:
  • iOS: Two new crashes, both with a single instance
  • Android: The only fresh issue is from an previous release and has 2 instances
• App Timing looking reasonable
• Github up ✅

[Julesssss]

[os-botify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Julesssss]