-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enlarge emojis in other contexts than just single character messages #47547
Open
VickyStash
wants to merge
54
commits into
Expensify:main
Choose a base branch
from
VickyStash:feature/large-emojis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 43 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
8d93e58
WIP on emojis enlarge
VickyStash 8fdd879
Add more options for testing
VickyStash 1a776ab
Improve messages with enlarged emojis display
VickyStash 957737a
Code clean up
VickyStash 18997d9
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 27fb058
Fix composer height when only emojis are entered
VickyStash 3ab61f4
Increase emojis in the display name
VickyStash 2b0caa2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash e750501
Fix emojis are cut off in some places on ios
VickyStash 3175d40
Lint fixes
VickyStash 8b0828b
Try to fix react compiler error
VickyStash 776aacd
Resolve TODO related to the text selection
VickyStash 6981d7c
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 41ffb05
Fix cursor jumping on ios
VickyStash 2007c58
Fix emojis are cut off in the workspace list on ios
VickyStash 9250cd9
Fix composer height
VickyStash 46ddde2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 2dd7773
Lint fix
VickyStash cc8e8b1
Fix large emojis overlap
VickyStash 435e777
Improve sender display
VickyStash d8a3fd2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 6ef2595
Lint fix
VickyStash 25a4ee9
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 7cf9b77
Fix emoji alignment
VickyStash 3af678f
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 272a32d
Update display name emoji size after merging main
VickyStash 87e41e5
Compiler fix
VickyStash dda7fdf
Code improvement
VickyStash 0705fee
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 8ecc202
Fix web emoji display
VickyStash 3e2f369
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 4f4ca61
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 9c30d73
Add missed import
VickyStash 528c08f
Fix regex usage
VickyStash eb3a958
Fix only emojis cropping in the composer on ios
VickyStash 1befeeb
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash ba756a5
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 4713c7e
Fix lint check errors
VickyStash 35af453
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 70190a4
Minor fix
VickyStash 743d3c2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash bce816d
TS fix
VickyStash 9a4883b
Update react-native-live-markdown version
VickyStash cde40ee
Revert "Update react-native-live-markdown version"
VickyStash 8e703d2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 592dc56
Add keys to get rid of lint errors
VickyStash 8010e02
Clean up code duplicates
VickyStash b2fe231
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 0c14e87
Reapply changes after merging main
VickyStash 8241ac7
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 4c584f0
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 9d4a4e2
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 8457803
Merge branch 'refs/heads/main' into feature/large-emojis
VickyStash 471c98e
Reapply fix after conflicts resolution
VickyStash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 13 additions & 2 deletions
15
src/components/HTMLEngineProvider/HTMLRenderers/EmojiRenderer.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/components/WorkspacesListRowDisplayName/index.native.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import React from 'react'; | ||
import Text from '@components/Text'; | ||
import useThemeStyles from '@hooks/useThemeStyles'; | ||
import * as EmojiUtils from '@libs/EmojiUtils'; | ||
import type WorkspacesListRowDisplayNameProps from './types'; | ||
|
||
function WorkspacesListRowDisplayName({isDeleted, ownerName}: WorkspacesListRowDisplayNameProps) { | ||
const styles = useThemeStyles(); | ||
const processedOwnerName = EmojiUtils.splitTextWithEmojis(ownerName); | ||
|
||
return ( | ||
<Text | ||
numberOfLines={1} | ||
style={[styles.labelStrong, isDeleted ? styles.offlineFeedback.deleted : {}]} | ||
> | ||
{processedOwnerName.length !== 0 | ||
? processedOwnerName.map(({text, isEmoji}) => | ||
isEmoji ? <Text style={[styles.labelStrong, isDeleted ? styles.offlineFeedback.deleted : {}, styles.emojisWithTextFontFamily]}>{text}</Text> : text, | ||
) | ||
: ownerName} | ||
</Text> | ||
); | ||
} | ||
|
||
WorkspacesListRowDisplayName.displayName = 'WorkspacesListRowDisplayName'; | ||
|
||
export default WorkspacesListRowDisplayName; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import React from 'react'; | ||
import Text from '@components/Text'; | ||
import useThemeStyles from '@hooks/useThemeStyles'; | ||
import type WorkspacesListRowDisplayNameProps from './types'; | ||
|
||
function WorkspacesListRowDisplayName({isDeleted, ownerName}: WorkspacesListRowDisplayNameProps) { | ||
const styles = useThemeStyles(); | ||
|
||
return ( | ||
<Text | ||
numberOfLines={1} | ||
style={[styles.labelStrong, isDeleted ? styles.offlineFeedback.deleted : {}]} | ||
> | ||
{ownerName} | ||
</Text> | ||
); | ||
} | ||
|
||
WorkspacesListRowDisplayName.displayName = 'WorkspacesListRowDisplayName'; | ||
|
||
export default WorkspacesListRowDisplayName; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
type WorkspacesListRowDisplayNameProps = { | ||
/** Should the deleted style be applied */ | ||
isDeleted: boolean; | ||
|
||
/** Workspace owner name */ | ||
ownerName: string; | ||
}; | ||
|
||
export default WorkspacesListRowDisplayNameProps; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the inline images were added in version
0.1.145,
you can only bump it to0.1.144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I need at least
0.1.146
cause it has web fixes for this pr...