Enlarge emojis in other contexts than just single character messages #47547

VickyStash · 2024-08-16T07:27:47Z

Details

This is another try to merge the PR related to emojis enlarging, the previous one was reverted.

Fixed Issues

$ #4114
Potentially fixing #14753
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Composer:

Draft a message (of any length) with text and emojis
Verify that emojis are larger (17px) compared to the default size for text (15px) in the composer (emojis + text input)

Report history:

Send a message with emojis and text
Verify that emojis are larger (17px) compared to the default size for text (15pt) in the chat history and vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji [$1000] Make emojis larger in other contexts than just single character messages #4114 (comment)

Settings:

Go to Settings -> Profile and add emoji to your last name
Verify that emoji appear larger (17px) than the rest of the text (15pt) in the text input
Save the changes
Open LHP
Verify that emoji in user's last name appear larger (25px) compared to the rest of the text (22px)

Offline tests

Same as in the Tests section.

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

# Conflicts: # src/components/Composer/index.tsx

melvin-bot · 2024-08-20T15:12:46Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-08-21T10:08:36Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/components/Composer/index.native.tsx # src/pages/home/report/comment/TextCommentFragment.tsx

parasharrajat · 2024-10-16T04:29:18Z

@VickyStash One bug and needs merge main.

parasharrajat · 2024-10-16T04:48:54Z

I will be on leave till 25th oct. I will wrap up the Checklist afterwards.

# Conflicts: # src/components/Composer/index.tsx

VickyStash · 2024-10-16T09:04:55Z

@parasharrajat In Chrome it looks bigger too, see the comparison of dev/prod:
DEV:

PROD:

shawnborton · 2024-10-28T08:43:56Z

Let us know when the next round of screenshots are ready for review!

pecanoro · 2024-10-30T00:57:59Z

@VickyStash Would be possible to check if this PR will fix this issue? Thank you!

VickyStash · 2024-10-30T06:54:55Z

@VickyStash Would be possible to check if this PR will fix this #14753? Thank you!

@pecanoro No, unfortunately, it's not. I was able to reproduce the issue.

Screenshot

VickyStash · 2024-10-30T09:27:44Z

I'm going to be OOO Oct 31 - Nov 3 🌴

# Conflicts: # src/pages/home/report/comment/TextCommentFragment.tsx

parasharrajat · 2024-11-04T17:31:34Z

I will run another round of testing in sometime.

shawnborton · 2024-11-08T14:31:43Z

How is this one going? Looks like we have some merge conflicts now...

# Conflicts: # src/components/AccountSwitcher.tsx # src/libs/ValidationUtils.ts

VickyStash · 2024-11-08T15:02:37Z

I've resolved conflicts, kind bump @parasharrajat

VickyStash · 2024-11-12T08:32:17Z

@parasharrajat any ETA on taking a look at this one?

parasharrajat · 2024-11-13T07:26:45Z

I will get this done on 3 hours.

parasharrajat · 2024-11-13T15:12:57Z

BUG: Android: Cursor is smaller on next line but pressing space increases its size.

Expected: Cursor should remain bigger when composer contains all emojies.

13.11.2024_20.41.13_REC.mp4

parasharrajat · 2024-11-13T17:30:12Z

BUG: Similiar issue on web #47547 (comment).

13.11.2024_22.59.20_REC.mp4

VickyStash · 2024-11-14T11:55:49Z

@parasharrajat @shawnborton Is it really an issue? I see slack acts the same for example:

slack_example.mp4

Fixing it can be tricky a little and cause some side issues. So I just want to confirm we really want to do it.

parasharrajat · 2024-11-14T16:28:45Z

I would say not a big deal. This does not occur on iOS.

VickyStash · 2024-11-15T11:50:39Z

Oh, we have conflicts again. I'm going to resolve them soon, though this one can be tricky.

shawnborton · 2024-11-15T12:14:32Z

Cool, I think it's okay to let it slide. Let's get this one over the finish line though, we're so close!

# Conflicts: # src/components/Composer/implementation/index.tsx # src/libs/ComposerUtils/updateIsFullComposerAvailable.ts

VickyStash · 2024-11-15T14:28:26Z

@parasharrajat Take a look, please 🙏

parasharrajat · 2024-11-15T15:25:05Z

Running through checklist now.

parasharrajat · 2024-11-15T18:27:39Z

Screenshots

🔲 iOS / native

15.11.2024_23.43.00_REC.mp4

🔲 iOS / Safari

15.11.2024_23.40.24_REC.mp4

🔲 MacOS / Desktop

15.11.2024_23.34.58_REC.mp4

🔲 MacOS / Chrome

15.11.2024_22.41.34_REC.mp4

🔲 Android / Chrome

15.11.2024_23.45.10_REC.mp4

🔲 Android / native

15.11.2024_23.37.17_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

VickyStash added 11 commits August 8, 2024 11:53

WIP on emojis enlarge

8d93e58

Add more options for testing

8fdd879

Improve messages with enlarged emojis display

1a776ab

Code clean up

957737a

Merge branch 'refs/heads/main' into feature/large-emojis

18997d9

Fix composer height when only emojis are entered

27fb058

Increase emojis in the display name

3ab61f4

Merge branch 'refs/heads/main' into feature/large-emojis

2b0caa2

Fix emojis are cut off in some places on ios

e750501

Lint fixes

3175d40

Try to fix react compiler error

8b0828b

VickyStash mentioned this pull request Aug 16, 2024

[$1000] Make emojis larger in other contexts than just single character messages #4114

Open

VickyStash added 6 commits August 19, 2024 15:48

Resolve TODO related to the text selection

776aacd

Merge branch 'refs/heads/main' into feature/large-emojis

6981d7c

Fix cursor jumping on ios

41ffb05

Fix emojis are cut off in the workspace list on ios

2007c58

Fix composer height

9250cd9

Merge branch 'refs/heads/main' into feature/large-emojis

46ddde2

# Conflicts: # src/components/Composer/index.tsx

VickyStash added 3 commits August 20, 2024 17:29

Lint fix

2dd7773

Fix large emojis overlap

cc8e8b1

Improve sender display

435e777

VickyStash changed the title ~~[WIP] Enlarge emojis in other contexts than just single character messages~~ Enlarge emojis in other contexts than just single character messages Aug 21, 2024

VickyStash marked this pull request as ready for review August 21, 2024 10:08

VickyStash requested review from a team as code owners August 21, 2024 10:08

melvin-bot bot requested review from parasharrajat and removed request for a team August 21, 2024 10:08

Merge branch 'refs/heads/main' into feature/large-emojis

d8a3fd2

# Conflicts: # src/components/Composer/index.native.tsx # src/pages/home/report/comment/TextCommentFragment.tsx

VickyStash added 2 commits October 16, 2024 11:39

Merge branch 'refs/heads/main' into feature/large-emojis

b2fe231

# Conflicts: # src/components/Composer/index.tsx

Reapply changes after merging main

0c14e87

Merge branch 'refs/heads/main' into feature/large-emojis

8241ac7

Merge branch 'refs/heads/main' into feature/large-emojis

4c584f0

# Conflicts: # src/pages/home/report/comment/TextCommentFragment.tsx

Merge branch 'refs/heads/main' into feature/large-emojis

9d4a4e2

# Conflicts: # src/components/AccountSwitcher.tsx # src/libs/ValidationUtils.ts

VickyStash added 2 commits November 15, 2024 14:53

Merge branch 'refs/heads/main' into feature/large-emojis

8457803

# Conflicts: # src/components/Composer/implementation/index.tsx # src/libs/ComposerUtils/updateIsFullComposerAvailable.ts

Reapply fix after conflicts resolution

471c98e

parasharrajat approved these changes Nov 15, 2024

View reviewed changes

melvin-bot bot requested a review from roryabraham November 15, 2024 18:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enlarge emojis in other contexts than just single character messages #47547

Enlarge emojis in other contexts than just single character messages #47547

VickyStash commented Aug 16, 2024 •

edited by pecanoro

Loading

melvin-bot bot commented Aug 20, 2024

melvin-bot bot commented Aug 21, 2024

parasharrajat commented Oct 16, 2024

parasharrajat commented Oct 16, 2024

VickyStash commented Oct 16, 2024

shawnborton commented Oct 28, 2024

pecanoro commented Oct 30, 2024

VickyStash commented Oct 30, 2024

VickyStash commented Oct 30, 2024

parasharrajat commented Nov 4, 2024

shawnborton commented Nov 8, 2024

VickyStash commented Nov 8, 2024

VickyStash commented Nov 12, 2024

parasharrajat commented Nov 13, 2024

parasharrajat commented Nov 13, 2024

parasharrajat commented Nov 13, 2024

VickyStash commented Nov 14, 2024

parasharrajat commented Nov 14, 2024

VickyStash commented Nov 15, 2024

shawnborton commented Nov 15, 2024

VickyStash commented Nov 15, 2024

parasharrajat commented Nov 15, 2024

parasharrajat commented Nov 15, 2024

parasharrajat left a comment

Enlarge emojis in other contexts than just single character messages #47547

Are you sure you want to change the base?

Enlarge emojis in other contexts than just single character messages #47547

Conversation

VickyStash commented Aug 16, 2024 • edited by pecanoro Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 20, 2024

melvin-bot bot commented Aug 21, 2024

parasharrajat commented Oct 16, 2024

parasharrajat commented Oct 16, 2024

VickyStash commented Oct 16, 2024

shawnborton commented Oct 28, 2024

pecanoro commented Oct 30, 2024

VickyStash commented Oct 30, 2024

VickyStash commented Oct 30, 2024

parasharrajat commented Nov 4, 2024

shawnborton commented Nov 8, 2024

VickyStash commented Nov 8, 2024

VickyStash commented Nov 12, 2024

parasharrajat commented Nov 13, 2024

parasharrajat commented Nov 13, 2024

parasharrajat commented Nov 13, 2024

VickyStash commented Nov 14, 2024

parasharrajat commented Nov 14, 2024

VickyStash commented Nov 15, 2024

shawnborton commented Nov 15, 2024

VickyStash commented Nov 15, 2024

parasharrajat commented Nov 15, 2024

parasharrajat commented Nov 15, 2024

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

VickyStash commented Aug 16, 2024 •

edited by pecanoro

Loading