Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode Base64 usernames/passwords as UTF-8 strings #269

Merged
merged 34 commits into from
Nov 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
29db3b9
* fixed user credentials encoding
RagingKore Oct 12, 2023
16dd1b9
* tests: removed linked files and added new project for common code
RagingKore Oct 16, 2023
9dcb10f
* removed solution file leftovers of another project
RagingKore Oct 16, 2023
c340a42
* upgraded ConfigureAwait analyzer
RagingKore Oct 17, 2023
fa00978
* nicer fixture with all clients
RagingKore Oct 17, 2023
33512f3
* implicit usings on tests and file scoped namespaces
RagingKore Oct 21, 2023
e39d52d
* no more IClassFixture
RagingKore Oct 24, 2023
67e9132
* more refactored tests.
RagingKore Oct 30, 2023
41f7f7e
* fixed some tests
RagingKore Oct 31, 2023
816361f
* removed dotnet 5 from ci scripts
RagingKore Oct 31, 2023
2fcc7f5
* added System.Text.RegularExpressions explicitly in tests to avoid e…
RagingKore Oct 31, 2023
8920870
* removed generators reference in test props
RagingKore Oct 31, 2023
5189685
* quickly added some assembly info files to disable parallel test...
RagingKore Oct 31, 2023
e8e3182
* attempt to improve docker isolation in tests
RagingKore Nov 2, 2023
35bcee4
* isolated the shutdown node test
RagingKore Nov 2, 2023
8f33893
* optimized warmup retry delays
RagingKore Nov 3, 2023
305c857
* removed zombie packages
RagingKore Nov 3, 2023
0604bba
* another attempt
RagingKore Nov 3, 2023
9b27aaf
* increased health check timeout
RagingKore Nov 3, 2023
4b248e7
* go go go
RagingKore Nov 3, 2023
8753089
* disabled all parallel tests and adjusted the tooling.
RagingKore Nov 6, 2023
477c03a
* small stuff
RagingKore Nov 6, 2023
418e996
* generate simple passwords for lts compatibility (this might be it)
RagingKore Nov 7, 2023
9ef5f57
* re-activating warmup logic
RagingKore Nov 7, 2023
ba3de54
* is it the warmup now?
RagingKore Nov 7, 2023
3228da0
* activated parallel test for operations and users
RagingKore Nov 7, 2023
17bcbf4
* disabled parallel tests. at this point CI hates them.
RagingKore Nov 7, 2023
609f706
* disable fail fast for tests
RagingKore Nov 7, 2023
89dd71a
* can't use log message for checking container health
RagingKore Nov 7, 2023
78db186
reverted the removal of dotnet 5
RagingKore Nov 9, 2023
766198a
* fixed .net 5 missing references and exceptions
RagingKore Nov 9, 2023
42077a0
* added back net5.0 target to samples
RagingKore Nov 9, 2023
82ad41b
* fixed samples build
RagingKore Nov 9, 2023
519ec26
* removed AuthenticationHeaderValue ctor from user credentials (and t…
RagingKore Nov 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 4 additions & 4 deletions .github/workflows/base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
strategy:
fail-fast: false
matrix:
framework: [net5.0, net6.0, net7.0]
os: [ubuntu-latest]
test: [Streams, PersistentSubscriptions, Operations, UserManagement, ProjectionManagement]
configuration: [release]
framework: [ net5.0, net6.0, net7.0 ]
os: [ ubuntu-latest ]
test: [ Streams, PersistentSubscriptions, Operations, UserManagement, ProjectionManagement ]
configuration: [ release ]
runs-on: ${{ matrix.os }}
name: EventStore.Client.${{ matrix.test }}/${{ matrix.os }}/${{ matrix.framework }}/${{ inputs.docker-tag }}
steps:
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/dispatch.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
name: "Dispatch"

on:
workflow_dispatch:
inputs:
version:
description: "Docker tag version"
required: true
type: string
workflow_dispatch:
inputs:
version:
description: "Docker tag version"
required: true
type: string

jobs:
test:
uses: ./.github/workflows/base.yml
with:
docker-tag: ${{ inputs.version }}
test:
uses: ./.github/workflows/base.yml
with:
docker-tag: ${{ inputs.version }}
11 changes: 5 additions & 6 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,13 @@ jobs:
find samples/ -type f -iname "*.csproj" -print0 | xargs -0L1 dotnet run --framework ${{ matrix.framework }} --project

test:
timeout-minutes: 10
timeout-minutes: 20
strategy:
fail-fast: false
matrix:
framework: [net5.0, net6.0, net7.0]
os: [ubuntu-latest, windows-latest]
configuration: [release]
framework: [ net5.0, net6.0, net7.0 ]
os: [ ubuntu-latest, windows-latest ]
configuration: [ release ]
runs-on: ${{ matrix.os }}
name: test/EventStore.Client/${{ matrix.os }}/${{ matrix.framework }}
steps:
Expand Down Expand Up @@ -161,5 +161,4 @@ jobs:
run: |
dotnet nuget list source
dotnet tool restore
find . -name "*.nupkg" | xargs -n1 dotnet nuget push --api-key=${{ secrets.nuget_key }} --source https://api.nuget.org/v3/index.json --skip-duplicate

find . -name "*.nupkg" | xargs -n1 dotnet nuget push --api-key=${{ secrets.nuget_key }} --source https://api.nuget.org/v3/index.json --skip-duplicate
35 changes: 18 additions & 17 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
<Project>
<PropertyGroup>
<TargetFrameworks>net5.0;net6.0;net7.0</TargetFrameworks>
<Platform>x64</Platform>
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
<Nullable>enable</Nullable>
<NullableContextOptions>enable</NullableContextOptions>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>11</LangVersion>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<DebugType Condition=" '$(Configuration)' == 'Debug' ">full</DebugType>
<DebugType Condition=" '$(Configuration)' == 'Release' ">pdbonly</DebugType>
<OutputPath>$(MSBuildThisFileDirectory)\bin\$(Configuration)\$(MSBuildProjectName)\</OutputPath>
<RootNamespace>EventStore.Client</RootNamespace>
<UseLinkBase>true</UseLinkBase>
<GrpcPackageVersion>2.49.0</GrpcPackageVersion>
<GrpcToolsPackageVersion>2.50.0</GrpcToolsPackageVersion>
</PropertyGroup>
<PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did tabs get changed to spaces here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix on another PR of "cosmetic" nature. And yes I'm struggling with tabs a lot XD

<TargetFrameworks>net5.0;net6.0;net7.0;</TargetFrameworks>
<Platform>x64</Platform>
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
<Nullable>enable</Nullable>
<NullableContextOptions>enable</NullableContextOptions>
<ImplicitUsings>true</ImplicitUsings>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>preview</LangVersion>

<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<DebugType Condition=" '$(Configuration)' == 'Debug' ">full</DebugType>
<DebugType Condition=" '$(Configuration)' == 'Release' ">pdbonly</DebugType>

<UseLinkBase>true</UseLinkBase>
<GrpcPackageVersion>2.49.0</GrpcPackageVersion>
<GrpcToolsPackageVersion>2.50.0</GrpcToolsPackageVersion>
</PropertyGroup>
</Project>
6 changes: 3 additions & 3 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
</Project>
14 changes: 6 additions & 8 deletions EventStore.Client.sln
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EventStore.Client.Persisten
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EventStore.Client.UserManagement.Tests", "test\EventStore.Client.UserManagement.Tests\EventStore.Client.UserManagement.Tests.csproj", "{22634CEE-4F7B-4679-A48D-38A2A8580ECA}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "generators", "generators", "{57BAB29D-F8A8-47C7-B426-89A1929ADD70}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EventStore.Tests.SourceGenerators", "generators\EventStore.Tests.SourceGenerators\EventStore.Tests.SourceGenerators.csproj", "{5912BD08-DA99-49B7-A2C0-C1BA42D209CB}"
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "EventStore.Client.Tests.Common", "test\EventStore.Client.Tests.Common\EventStore.Client.Tests.Common.csproj", "{E326832D-DE52-4DE4-9E54-C800908B75F3}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Expand Down Expand Up @@ -92,10 +90,10 @@ Global
{22634CEE-4F7B-4679-A48D-38A2A8580ECA}.Debug|x64.Build.0 = Debug|Any CPU
{22634CEE-4F7B-4679-A48D-38A2A8580ECA}.Release|x64.ActiveCfg = Release|Any CPU
{22634CEE-4F7B-4679-A48D-38A2A8580ECA}.Release|x64.Build.0 = Release|Any CPU
{5912BD08-DA99-49B7-A2C0-C1BA42D209CB}.Debug|x64.ActiveCfg = Debug|Any CPU
{5912BD08-DA99-49B7-A2C0-C1BA42D209CB}.Debug|x64.Build.0 = Debug|Any CPU
{5912BD08-DA99-49B7-A2C0-C1BA42D209CB}.Release|x64.ActiveCfg = Release|Any CPU
{5912BD08-DA99-49B7-A2C0-C1BA42D209CB}.Release|x64.Build.0 = Release|Any CPU
{E326832D-DE52-4DE4-9E54-C800908B75F3}.Debug|x64.ActiveCfg = Debug|Any CPU
{E326832D-DE52-4DE4-9E54-C800908B75F3}.Debug|x64.Build.0 = Debug|Any CPU
{E326832D-DE52-4DE4-9E54-C800908B75F3}.Release|x64.ActiveCfg = Release|Any CPU
{E326832D-DE52-4DE4-9E54-C800908B75F3}.Release|x64.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{D3744A86-DD35-4104-AAEE-84B79062C4A2} = {EA59C1CB-16DA-4F68-AF8A-642A969B4CF8}
Expand All @@ -110,6 +108,6 @@ Global
{FC829F1B-43AD-4C96-9002-23D04BBA3AF3} = {C51F2C69-45A9-4D0D-A708-4FC319D5D340}
{6CEB731F-72E1-461F-A6B3-54DBF3FD786C} = {C51F2C69-45A9-4D0D-A708-4FC319D5D340}
{22634CEE-4F7B-4679-A48D-38A2A8580ECA} = {C51F2C69-45A9-4D0D-A708-4FC319D5D340}
{5912BD08-DA99-49B7-A2C0-C1BA42D209CB} = {57BAB29D-F8A8-47C7-B426-89A1929ADD70}
{E326832D-DE52-4DE4-9E54-C800908B75F3} = {C51F2C69-45A9-4D0D-A708-4FC319D5D340}
EndGlobalSection
EndGlobal
Loading
Loading