Decode Base64 usernames/passwords as UTF-8 strings #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed incorrect usage of Assert on some tests * added Shouldy and Bogus to tests * refactored some tests accordingly * added minor formatting rules * upgraded several nuget packages in the test projects
* tests: created new fixture and supporting container components * tests: global usings for a few tools
* new warmup function attempt :P
* added solution settings * major cleanup on tests
* code reformat where possible for better readability
* optimized test fixtures. * reverted spaces to tabs...
* fixed legacy test runners not finding certs * moved test logger configuration to settings file * deleted zombie files
…rrors * reverted editor config
RagingKore
requested review from
pvanbuijtene,
hayley-jean,
thefringeninja and
timothycoleman
* removed zombie code
|
Tests run great locally, but are flaky when running on CI. Having another look at this before making it ready for review again. |
RagingKore
changed the title
* minor refactor of global environments
* disabled ES atom pub and log file
* fail fast for ci tests
* by default run the oldest lts instead of ci image * fixed gencert cli version mismatch
* fixing tabs
* fixed clients warmup * killed zombie code
* code format on samples project files.
RagingKore
changed the title
Perhaps this should be
probably best mention utf8 anyway |
| <GrpcPackageVersion>2.49.0</GrpcPackageVersion> | ||
| <GrpcToolsPackageVersion>2.50.0</GrpcToolsPackageVersion> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
did tabs get changed to spaces here?
There was a problem hiding this comment.
Will fix on another PR of "cosmetic" nature. And yes I'm struggling with tabs a lot XD
| @@ -0,0 +1,405 @@ | |||
| <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation"> | |||
There was a problem hiding this comment.
dotsettings and editorconfig are going to conflict, aren't they?
There was a problem hiding this comment.
I believe they will and we can create a new PR to align those.
thefringeninja
approved these changes
Nov 21, 2023
timothycoleman
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Support for UTF8 usernames and passwords
Changed: full cleanup from code format to structure (added .DotSettings)
Changed: created a tests common project to share fixtures and more.
Changed: brand new fixtures and fluent docker abstractions.
Changed: added Shouldy for test assertions.
Changed: added Bogus for creating object fakers.
Changed: removed source generators to provide a path to certs and now simply copy them over.
Changed: refactored client warmup functions.