-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1251 #1390
Issue 1251 #1390
Conversation
… material entity'
@@ -1,231 +1 @@ | |||
http://purl.obolibrary.org/obo/FOODON_00001081 # Bondon cheese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to delete all of these?
Hi @pbuttigieg Unfortunately reviewing this PR is very difficult as it was started from an old PR and has many of the changes that happened on master merged in, so everything is all mixed together in the PR. I'm going to consult with some others on the best way to proceed here. (There are many approaches ranging from cherry picking through to rebasing through to simply redoing the work). I will report back later. |
It looks like all intended changes were in one commit. I did a diff of this to help us review:
|
This is a really important PR. There are lots of much needed changes in these, for example, moving a lot of currently very useful classes from immaterial to material entities. I'm going to prioritize rescuing this. |
Replaced by #1430 |
Supercedes #1252