Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1251] 'astronomical body part' - change parent #1252

Closed
wants to merge 6 commits into from

Conversation

dr-shorthair
Copy link

@dr-shorthair dr-shorthair commented Nov 24, 2021

from 'fiat object part' to 'material entity'

Fixes #1251

@dr-shorthair dr-shorthair mentioned this pull request Nov 24, 2021
@dr-shorthair dr-shorthair requested review from cmungall and a team November 24, 2021 22:44
@cmungall
Copy link
Member

I heartily approve this, but a high level change requires consensus - what do you think @pbuttigieg, are we ready for this?

@dr-shorthair dr-shorthair changed the title 'astronomical body part' - change parent [#1251] 'astronomical body part' - change parent Nov 24, 2021
@kaiiam
Copy link
Contributor

kaiiam commented Nov 25, 2021

I ask the question what benefit do we get from keeping astronomical body part and environmental material as subclasses of fiat object part?

My understanding of fiat object part is that we're saying there is some 2D fiat boundary drawn up and bounding things. I can see that being more true for astronomical body part than environmental material. If there is a good rational that we want to keep such constraints on those hierarchies I'm all ears, otherwise perhaps we should consider pruning top level BFO terms such as fiat object part.

@diatomsRcool
Copy link
Contributor

Makes sense to me, but I am open to hearing counter arguments

@cmungall
Copy link
Member

cmungall commented Nov 29, 2021 via email

@kaiiam
Copy link
Contributor

kaiiam commented Nov 29, 2021

@cmungall I'm certainly no expert but I was getting that from the elucidation of fiat object part. Again I'm not sure what this buys us to continue including it in ENVO.

b is a fiat object part = Def. b is a material entity which is such that for all times t, if b exists at t then there is some object c such that b proper continuant_part of c at t and c is demarcated from the remainder of c by a two-dimensional continuant fiat boundary. (axiom label in BFO2 Reference: [027-004])

@cmungall
Copy link
Member

ah yes, my mistake, sorry! but the point remains, if it's important for users to be able to know which terms in ENVO represent things with fiat 2D boundaries we could add this as a property.

@pbuttigieg
Copy link
Member

I'm not sold on this - as we have seen time and again, most geographical entities are delimited by fiat, and different communities will set different boundaries (coasts, riparian zones, ...). Including different definitions to align with different community usages means we should acknowledge the fiat nature of the boundaries.

@dr-shorthair
Copy link
Author

dr-shorthair commented Nov 30, 2021

I suppose that depends on whether you see

  • defined according to rule A, conditioned by observations b, c, d

as a fiat choice.

I agree that different communities will set different rules and supporting observations. But the general sense is that a delimitation that emerges from rules that are designed to encode natural phenomena is qualitatively different to a rule that is based on drawing an arbitrary line on a map/landscape.

On the other hand, if there is no 'natural' delimitation, then is there any partition of space that is not fiat? In which case 'fiat' is not a particularly useful distinction.

@smrgeoinfo
Copy link

Seems to me that there is a subjective continuum between what is 'fiat' and things that have 'hard' boundaries. Perhaps the distinction is based on the degree to which multiple observers would all agree on the same boundary. Consensus being the criteria for 'hard' boundaries, and valid alternate interpretations being the criteria for fiat: some authority makes a decision abut the interpretation that will be used. So the boundary of the 'Empire State building' (as a non-fiat example) and the boundary of the Rhine River flood plain (fiat--requires adoption of one interpretation of 'floodplain' and the available observation evidence).

Can ontological distinction be made between an 'object' (non-fiat, there is consensus, or close enough, about its boundaries) and 'fiat objects', with boundaries based on interpretation of entity definition and observation evidence. In this view, there are likely astronomical body parts that are 'objects' and parts that are 'fiat objects'.

@wdduncan
Copy link
Member

wdduncan commented Dec 3, 2021

FWIW, there seems to be unending debate about these matter. E.g., see Barry Smith and Mark Do Mountains Exist.
If we want to classify mounts, deserts, caves, etc. as fiat objects, it would be useful if the fiat nature served some purpose in terms of reasoning. Currently, fiat object doesn't seem to serve such a purpose.

@dr-shorthair
Copy link
Author

@wdduncan thanks for the reference - I vaguely recall seeing it before, but now I have a more immediate interest in the question.

Nevertheless, I agree with your proposition that the classification 'fiat' is not useful unless it assists reasoning. Since http://purl.obolibrary.org/obo/BFO_0000024 currently has no axioms, then it currently does not. I'm generally skeptical of the utility of any sub-class that doesn't formally differentiate itself from the parent.

@kaiiam
Copy link
Contributor

kaiiam commented Dec 3, 2021

Nevertheless, I agree with your proposition that the classification 'fiat' is not useful unless it assists reasoning. Since http://purl.obolibrary.org/obo/BFO_0000024 currently has no axioms, then it currently does not. I'm generally skeptical of the utility of any sub-class that doesn't formally differentiate itself from the parent.

I mostly agree with this too. I think there is probably some value in keeping the BFO term as it add a differentia to humans readers, but it does not add anything to machine systems or reasoning capabilities.

Perhaps I could suggest two possible options?

  1. keep BFO:0000024 but add an axiom to it presumably linking to BFO:two-dimensional continuant fiat boundary

  2. @cmungall's compromise suggestion of dropping BFO:0000024 but instead "assert this as a has-characteristic axiom at whatever level of ENVO we feel appropriate ... relating to boundaries that we feel is important for some use case[s]"

Thoughts?

@wdduncan
Copy link
Member

wdduncan commented Dec 3, 2021

Not sure if has characteristic would work as an axiom. Perhaps something like has part some continuant fiat boundary might work too. But, such a change should be communicated with the BFO editors for feedback.

Seems simpler to classify entities under material entity rather than wading into murky issues about what fiat boundaries are.

Do we have any clear examples of fiat objects? military training area may be such a case, since its boundaries are decided upon by fiat. Note, this sense of 'fiat' is different than entities having fuzzy boundaries, which is how Smith et al. using the term 'fiat'.

@cmungall
Copy link
Member

cmungall commented Dec 4, 2021 via email

@cmungall
Copy link
Member

cmungall commented Dec 4, 2021 via email

@cmungall
Copy link
Member

cmungall commented Dec 4, 2021 via email

@wdduncan
Copy link
Member

wdduncan commented Dec 5, 2021

Are we all in agreement that ABP should be moved under material entity?

@kaiiam
Copy link
Contributor

kaiiam commented Dec 6, 2021

@pbuttigieg how would you feel about @cmungall's suggestion of removing fiat object part but instead adding the following axioms to astronomical body part?

  1. ABP SubClassOf material entity
  2. ABP SubClassOf has_part some BFO:two-dimensional continuant fiat
    boundary

@LarsVogt
Copy link

I can only support the proposal to ignore the distinction between fiat object part and object. The question, what characterizes an object, is an open question (I think, the question is not, what a fiat object part is, but rather what a bona fide object is).

BFO 1.0 has characterized object and fiat object part in reference to fiat and bona fide boundaries, with the latter being defined as mind-independent demarcations (i.e., they exist independent of any human partitioning activities) that rest on some physical discontinuity or qualitative heterogeneity. The problem with the second criterion (physical discontinuity & qualitative heterogeneity) is that these are very much granularity dependent - at some granularity level, every physical entity becomes a fiat object part. I have discussed this problem here: https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0048603

As a consequence of this critique, in BFO 2.0, the focus has been changed from boundary types to causal unity. But this is still work in progress, I think, because you still find some reference to boundaries (see elucidation for fiat object part). Also,the list of causal unity types suggested in BFO 2.0 is confined to a synchronic approach to causal unity that is associated with a spatio-structural frame of reference - it does not take the dynamic nature of reality into account. I think, a human heart is a functional unit and thus, in a functional frame of reference, a bona fide functional object that exists independent of any human partitioning activities. In the same way, I can demarcate developmental units and evolutionary units. As a consequence, further causal unity types must be added to the list. The main problem here, however, is, that a given entity can be both a fiat object part and a bona fide object, depending on which frame of reference one is applying: spatio-structurally, the human heart is a fiat object part, but functionally it isn't. If you are interested in this discussion, you can read about it here:
https://jbiomedsem.biomedcentral.com/articles/10.1186/s13326-019-0196-2

Since this is all very complicated to manage and communicate to users for annotation purposes, I agree with the suggestion to take a pragmatic approach and ignore the categories of object and fiat object part and add respective information as axioms where needed, thus making this classification an implicit one.

@cmungall
Copy link
Member

Any update on this?

@kaiiam
Copy link
Contributor

kaiiam commented Jan 19, 2022

@pbuttigieg your thoughts?

@dr-shorthair
Copy link
Author

Can we finish this one?

@kaiiam
Copy link
Contributor

kaiiam commented Aug 18, 2022

I believe @cmungall @wdduncan and myself are in favor of this. However, we don't have a full consensus at the moment.

@pbuttigieg
Copy link
Member

I'll consider the arguments and make a decision for the next release in the next few days.

@pbuttigieg
Copy link
Member

pbuttigieg commented Aug 19, 2022

Implementation:

🚧 In progress 🚧

  • Modify magnetosphere for illustration on limits of material parthood
  • Incorporate example material part with both fiat and discontinuity-based boundaries
  • Incorporate example of part with entirely fiat boundaries - MPAs, testing sites, ...
  • Modify positioning of environmental zones
  • Establish and document position on fuzzy vs fiat

Copy link
Member

@pbuttigieg pbuttigieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an impactful change, which will require some rethinking of other top-level class alignments for conceptual coherence.

Building on the exchange here, I'll generate a solution for the next release.

@pbuttigieg pbuttigieg self-assigned this Aug 22, 2022
@dr-shorthair
Copy link
Author

Do you have a sense of where it impacts, in practice?

I totally agree that it is critical not to break things.
So am curious where and how the semantics of 'fiat object part' actually come into play.
(Particularly since there is no axiomatization of significance.)

@pbuttigieg
Copy link
Member

pbuttigieg commented Aug 26, 2022

Do you have a sense of where it impacts, in practice?

How we write definitions, classes and branches where boundaries matter and have fiat and/xor non-fiat components, the need to identify what kind of fiat boundaries exist (for axiomatisation but also to link with environmental authorities and capture how humans manage environmental systems).

So am curious where and how the semantics of 'fiat object part' actually come into play.

Where the boundaries of a part of something like Earth are declared by fiat. A marine protected area, chunks of the planet designated for weapons testing (as noted above), etc.

(Particularly since there is no axiomatization of significance.)

This can be said of many upper-level terms that are in wide use. It's also not the primary objective: representation of knowledge is a greater priority relative to whether or not some reasoner understands it (yet). If we define useful subclasses of the fiat boundaries (e.g. designated by national authorities), then this changes

@wdduncan
Copy link
Member

I don't think anyone is arguing that fiat objects don't exist. Rather, the issue that the default operating procedure seems to be that every astronomical body part is categorized as fiat, and this is too strong (for reasons already stated).

@pbuttigieg
Copy link
Member

I don't think anyone is arguing that fiat objects don't exist. Rather, the issue that the default operating procedure seems to be that every astronomical body part is categorized as fiat, and this is too strong (for reasons already stated).

Yes, that has been demonstrated.

@wdduncan
Copy link
Member

Yes, that has been demonstrated.

So, are you arguing that every astronomical body part is a fiat object part?

@dr-shorthair
Copy link
Author

every astronomical body part is a fiat object part

Hmm. I think I can see where @pbuttigieg is going here. When considering natural spatial entities, the envelope is inevitably arbitrary, or at least strongly determined by the discipline or application, or scale.

But perhaps the distinction is really a BFO question, and not an ENVO issue.
Is the distinction between fiat object part, and material entity actually useful in general?
Are there things in the OBO universe that are truly material entities whose boundaries are not in fact defined by fiat (or convention)?

@wdduncan
Copy link
Member

Are there things in the OBO universe that are truly material entities whose boundaries are not in fact defined by fiat (or convention)?

Sure. I think things like Earth's left hemisphere and geopolitical regions (e.g, cities) are fiat objects. However, I doubt that most scientists think of geographical features like lakes and archipelagos as being fiat objects (at least not in the sense in which Earth's hemispheres are fiat). Something to think about: what is the principle at work for defining an organic group as a material entity, but defining an archipelago as a fiat object?

Given the difficulties of rigorously defining of what it means to be a fiat object (aside from clear acts of human intention), I think it is better to default to defining things like lakes and mountains (an other astronomical body parts) as material entities. At least that way you aren't saying some wrong. That is, all fiat objects are material entities, but not all material entities are fiat objects.

This (I think) will make the ontology more clear to the community. If someone wants an entity to be a fiat object, we should make the reasons why really clear: that is, in what sense is the object being defined merely by human convention?

@dr-shorthair
Copy link
Author

@wdduncan you answered the inverse question.

As @pbuttigieg has argued, and I agree, pretty much every material entity in the natural world is strictly a fiat-object, when considering some applications and scale.

What I want to know is if there are any material objects that do not (arguably) have fiat boundaries?

If the answer is no, then the classes are identical and we don't need the distinction.

@smrgeoinfo
Copy link

In BFO materialEntity has subclasses 'object', 'fiat object part', and 'object aggregate'. Making 'astronomical body part' a subclass of materialEntity dodges the whole (subjective, context-dependent) problem of distinguishing an 'object' from an 'object part' or 'object aggregate' (is a forest an object, object part or an object aggregate?) ABP meets the axiom for materialEntity

@pbuttigieg
Copy link
Member

pbuttigieg commented Aug 28, 2022

Hello all - it is Sunday (here), but ontology never rests, I suppose .

Can't do a point-by-point, and tapping away on a smartphone, but here's a sense of where I'm headed, informed by the exchange above.

  • ABP will be moved under material entity (couldn't find an immaterial counterexample which doesn't have a material grounding)
  • Anything that is a part of an astronomical body will be reasoned under ABP, but will be placed where it most naturally falls in BFO or a high-level part of a BFO-aligned resource (object, ObjAgg, system, etc)
  • If there's no comfy BFO alignment for an entity, it can vacation under ABP until we have enough expertise or a large enough example set to move it.
  • Fuzzy boundaries (we know they are physically there, even if there's disagreement on where) will be distinguished from fiat boundaries (no reliable physical indicator they are there).
  • Fiat object part will contain things that are only there by fiat / only have fiat boundaries at a class level (hemispheres, protected area chunks of things). For these, we should also define the fiat boundary itself and link off to resources that define it (conventions, treaties, legal acts of desgnation ) where possible.
  • Other non-fiat object parts can have fiat boundaries (peaks of mountains), alongside their physical-if-fuzzy ones
  • Ambiguity / disagreement on physical boundaries should be handled by subclasses of an inclusively defined superclass, on the instance level, or by an extension/independent-yet-interoperating ontology built for a specific application case. Useful comments explaining ambiguities should be the norm (xref our ESIP cryosemantic harmonisation work for many handy and sometimes entertaining examples)
  • In general, definitions should focus on the processes of ABP formation rather than their boundaries - this allows nifty and useful axiomatisation with our improving process branch and leveraging / extension of RO's causal relations

I'm doing some ontosurgery to set the basis for the above. We'll run with that for the next release and see where it gets us.

@wdduncan
Copy link
Member

@dr-shorthair Sorry if I didn't understand your question/point.

There are (IMHO) never ending arguments about this.

I think it comes down to what you mean by 'fiat'. I think a reasonable way to think of a fiat object is that it is an object whose boundary exists b/c of human convention. This is not perfect, but I think it is good enough.

Having a fiat boundary is not exactly the same as having fuzzy boundaries (at some level of scale), or being capable of being divided in some arbitrary fashion.

@smrgeoinfo
Copy link

@pbuttigieg if you're going down that road, you could bite the non-BFO bullet:

materialEntity

  • object : has identity and unity (Guarino...)
    • material object: has hard boundary, that is a boundary with a material manifestation that can be defined as a surface at the scale of interest. Definition of the hard boundary can vary between observers, but once defined all can agree on its location.
    • fuzzy object : has fuzzy boundary: material manifestation of boundary exists, but its location is gradational at the scale of interest.
    • fiat object. boundary exists only as a human-defined artefact, with no physical manifestation (other that markers put there by humans)
  • substance : has identity, not unity

Objects have parts that are necessarily other objects
Objects are composed of some substance [For compatibility with existing ENVO, you'd have to leave out substance I suppose.... and say an object has a part that is a portion of some subtance. What is a portion?]

an astronomical body part is an object that is part of an astronomical body (which is an object). Most APBs would probably be fuzzy objects.

object aggregation: this needs some discussion-- is it a bunch of disconnected objects (a forest), or an object with many parts (an automobile). Call the mereology team.

@cmungall
Copy link
Member

cmungall commented Nov 7, 2022

Let me try and summarize where we are at with this. I know there are a lot of side issues going on, but I want to focus solely on this PR which is to change the parentage of ABP to from fiat object part to material entity.

I believe we have achieved consensus on this issue. On Aug 28, @pbuttigieg says:

ABP will be moved under material entity (couldn't find an immaterial counterexample which doesn't have a material grounding)

So we are all in agreement, ABP should be under material entity. This is the entire scope of the PR.

@pbuttigieg also says:

I'm doing some ontosurgery to set the basis for the above. We'll run with that for the next release and see where it gets us.

it looks like the last release is https://github.com/EnvironmentOntology/envo/releases/tag/v2021-05-14, a year and a half ago.

If we are all in agreement, I don't see a reason to block this PR on other unscoped work?

@pbuttigieg
Copy link
Member

I'm not done with my edits - apologies for the delay, but I don't want to lose the process so far

@pbuttigieg pbuttigieg mentioned this pull request Dec 5, 2022
@cmungall
Copy link
Member

cmungall commented Aug 26, 2023

We are approaching the 2nd anniversary of this PR

@pbuttigieg - it looks like you have a separate PR going:

It looks like this introduces a new intermediate class "fiat part of an astronomical object" in between ABP and BFO:FoP.

This is an improvement as it introduces a within-ENVO grouping, but I don't think it addresses the concerns raised on this PR.

New structure:

image image image

@pbuttigieg
Copy link
Member

I think we've addressed this in recent merges

@pbuttigieg
Copy link
Member

I think we've addressed this in recent merges

@pbuttigieg pbuttigieg closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Astronomical Body Part really a 'Fiat Object Part'?
8 participants