Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove caching, fixes #176 #178

Merged
merged 1 commit into from
Nov 16, 2023
Merged

remove caching, fixes #176 #178

merged 1 commit into from
Nov 16, 2023

Conversation

peterstadler
Copy link
Member

The caching was blocking further requests for different HTTP methods. So, once an e.g. OPTIONS request was cached with a 404, subsequent calls to the same endpoint but via GET where hitting the 404 as well

@peterstadler peterstadler added this to the Release 2.0 milestone Nov 15, 2023
@peterstadler peterstadler linked an issue Nov 15, 2023 that may be closed by this pull request
The caching was blocking further requests for different HTTP methods. So, once an e.g. OPTIONS request was cached with a 404, subsequent calls to the same endpoint but via GET where hitting the 404 as well
Copy link

@daniel-jettka daniel-jettka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this did the trick 👍

@daniel-jettka daniel-jettka merged commit 0eede61 into develop Nov 16, 2023
6 checks passed
@daniel-jettka daniel-jettka deleted the issue-176 branch November 16, 2023 13:31
@daniel-jettka daniel-jettka removed the request for review from peterprovaznik November 16, 2023 13:31
@peterprovaznik
Copy link
Collaborator

I have noticed that two other <dispatch> elements in data/controller.xql already had the <cache-control cache="no"/>, which makes me more confident that this is a good idea. :)
I have also had a look at eXist docs (https://exist-db.org/exist/apps/doc/urlrewrite#controller-xml) where it says that this caching concerns URL rewriting, which would explain why the HTTP method does not seem to be taken into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller caching fails CRUD endpoints for subsequent calls
3 participants