Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller caching fails CRUD endpoints for subsequent calls #176

Closed
peterstadler opened this issue Nov 15, 2023 · 0 comments · Fixed by #178
Closed

controller caching fails CRUD endpoints for subsequent calls #176

peterstadler opened this issue Nov 15, 2023 · 0 comments · Fixed by #178
Assignees
Labels
bug Something isn't working
Milestone

Comments

@peterstadler
Copy link
Member

When calling (via GET) e.g. http://localhost:8080/data/read?filename=incipit_demo.xml AND providing an Accept header ('application/json' or 'application/xml') the endpoint returns the requested XML file. However, after doing an OPTIONS request, this same call returns 404.

steps to reproduce

  1. curl -i -H "Accept: application/xml" "http://localhost:8080/data/read?filename=nielsen_cnw0131.xml" returns 200
  2. curl -I "http://localhost:8080/data/read?filename=nielsen_cnw0131.xml" returns 404
  3. curl -i -H "Accept: application/xml" "http://localhost:8080/data/read?filename=nielsen_cnw0131.xml" returns 404(!)
@peterstadler peterstadler added the bug Something isn't working label Nov 15, 2023
@peterstadler peterstadler added this to the Release 2.0 milestone Nov 15, 2023
peterstadler added a commit that referenced this issue Nov 15, 2023
The caching was blocking further requests for different HTTP methods. So, once an e.g. OPTIONS request was cached with a 404, subsequent calls to the same endpoint but via GET where hitting the 404 as well
@peterstadler peterstadler linked a pull request Nov 15, 2023 that will close this issue
peterstadler added a commit that referenced this issue Nov 16, 2023
The caching was blocking further requests for different HTTP methods. So, once an e.g. OPTIONS request was cached with a 404, subsequent calls to the same endpoint but via GET where hitting the 404 as well
daniel-jettka added a commit that referenced this issue Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants