ENH: added setup_storage_volume to account for green-infratructure #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o storage_volume
…o storage_volume
DirkEilander
requested changes
Nov 8, 2023
There was a problem hiding this comment.
I've just checked the code, not actually tested it.
Apart from some small comments, before merging, it would be good to
- move the lines 1611-1691 to a workflow script
- add a unit test with a gdf containing a point a polygon with and without volume/height attributes on a small rotated grid to make sure it works as expected.
hydromt_sfincs/sfincs.py
Outdated
Comment on lines
1656
to
1661
| # rotate the point | ||
| x, y = ~da_vol.raster.transform * (x, y) | ||
| # select the grid cell nearest to the point | ||
| closest_point = da_vol.reindex(x=da_vol.x, y=da_vol.y).sel( | ||
| x=x, y=y, method="nearest" | ||
| ) |
There was a problem hiding this comment.
I think this could be replaced with row,col = da_vol.raster.rowcol(x, y) after which you can use da_vol.iloc[row, col] later?
There was a problem hiding this comment.
This doesn't seem to work for me ..
DirkEilander
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an additional layer to the SfincsModel.grid to account for green-infrastructure. This layer describes a storage volume in m3 per cell that needs to be filled first before the cell becomes wet, and therefore mimics the presence of green-infrastructure.
input can be