Storage volume qtr nc #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or points with refinement neighbors where qx_nmu and qx_nmd were not defined). Also, smoothing now no longer occurs when neighbors are dry (the way it used to be in old versions). Also fixed bug where quadtree_nmax was not determined, which resulted in WRONG obs points for quadtree grids! This error was introduced in recent version with quadtree netcdf file option.
keesnederhoff
approved these changes
Jul 21, 2023
|
Thanks for checking Kees. I created a branch as well for the HydroMT-SFINCS part, see here By the way, I see that some checks are not passing, and I guess that has to do by this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added storage volume
Added netcdf quadtree file
Fixed theta smoothing