#146 and #125 gis functions in separate file and ground floor height updating #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update branch with latest fiat_integrator
This was
linked to
issues
Oct 19, 2023
…parate-file-and-ground-floor-height-updating
|
I now also created a test for polygon overlays |
Santonia27
approved these changes
Oct 30, 2023
Mares2022
approved these changes
Oct 30, 2023
|
Ready to commit, I will add new functions for getting ground elevation values per building into gis.py with the same code structure that has already been developed. |
…-and-ground-floor-height-updating
frederique-hub
deleted the
#146-and-#125-gis-functions-in-separate-file-and-ground-floor-height-updating
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both issues #146 and #125. Should still be tested with other data types (e.g., using a polygon file to overlay with). I'll create the tests for that as well