Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Don't write keywords with None values #663

Merged
merged 28 commits into from
Jul 5, 2024
Merged

feat: Don't write keywords with None values #663

merged 28 commits into from
Jul 5, 2024

Commits on Jul 4, 2024

  1. 661: Add integration test that should pass but currently fails.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3f2ff0d View commit details
    Browse the repository at this point in the history

  2. 661: Added some more tests that should pass but currently fail.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2ba7ed5 View commit details
    Browse the repository at this point in the history

  3. 661: Implemented potential solution.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ea51da6 View commit details
    Browse the repository at this point in the history

  4. 661: Improve solution. Deal with possible None values when getting th… 

    …e field.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    fdad8b2 View commit details
    Browse the repository at this point in the history

  5. 661: Remove deprecated keyword dtmassbalance.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    ae25d69 View commit details
    Browse the repository at this point in the history

  6. 661: Updated default values for several keywords and updated some des… 

    …criptions.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    3342ba4 View commit details
    Browse the repository at this point in the history

  7. 661: Set default value for sedimentmodelnr.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    d4963d2 View commit details
    Browse the repository at this point in the history

  8. 661: Updated testcase reference data.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    925ec0b View commit details
    Browse the repository at this point in the history

  9. 661: Updated testcase to take Unions and Lists into account. This cur… 

    …rently fails but should pass.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    50b5f66 View commit details
    Browse the repository at this point in the history

  10. 661: Updated implementation to take Unions and Lists into account.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    791abcb View commit details
    Browse the repository at this point in the history

  11. 661: Add integration test that should pass but currently fails.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c6bd0a1 View commit details
    Browse the repository at this point in the history

  12. 661: Added some more tests that should pass but currently fail.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    5f223a7 View commit details
    Browse the repository at this point in the history

  13. 661: Implemented potential solution.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c14bbc6 View commit details
    Browse the repository at this point in the history

  14. 661: Improve solution. Deal with possible None values when getting th… 

    …e field.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    cb284ad View commit details
    Browse the repository at this point in the history

  15. 661: Remove deprecated keyword dtmassbalance.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a8a8d12 View commit details
    Browse the repository at this point in the history

  16. 661: Updated default values for several keywords and updated some des… 

    …criptions.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    2cb3c27 View commit details
    Browse the repository at this point in the history

  17. 661: Set default value for sedimentmodelnr.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1b1a432 View commit details
    Browse the repository at this point in the history

  18. 661: Updated testcase reference data.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    890c0ad View commit details
    Browse the repository at this point in the history

  19. 661: Updated testcase to take Unions and Lists into account. This cur… 

    …rently fails but should pass.
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    bccf7bb View commit details
    Browse the repository at this point in the history

  20. 661: Updated implementation to take Unions and Lists into account.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0cbe2b0 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'feat/661_Dont-write-empty-keywords' of https://github.c… 

    …om/Deltares/HYDROLIB-core into feat/661_Dont-write-empty-keywords
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    117f70e View commit details
    Browse the repository at this point in the history

  22. 661: Remove obsolete keyword DtMassBalance from tests.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    443f610 View commit details
    Browse the repository at this point in the history

  23. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6062df1 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. 661: Implement review comments.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    194850e View commit details
    Browse the repository at this point in the history

  2. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5e98579 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/661_Dont-write-empty-keywords 

    # Conflicts:
#	tests/dflowfm/test_research.py
    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    275f332 View commit details
    Browse the repository at this point in the history

  4. 661: Update testcase reference data.

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c607dd4 View commit details
    Browse the repository at this point in the history

  5. autoformat: isort & black

    @tim-vd-aardweg
    tim-vd-aardweg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0b55490 View commit details
    Browse the repository at this point in the history