Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Don't write keywords with None values #663

Merged
merged 28 commits into from
Jul 5, 2024
Merged

feat: Don't write keywords with None values #663

merged 28 commits into from
Jul 5, 2024

Conversation

tim-vd-aardweg
Copy link
Contributor

refs: #661

tim-vd-aardweg and others added 23 commits July 4, 2024 14:38
@tim-vd-aardweg
661: Add integration test that should pass but currently fails.
3f2ff0d
@tim-vd-aardweg
661: Added some more tests that should pass but currently fail.
2ba7ed5
@tim-vd-aardweg
661: Implemented potential solution.
ea51da6
@tim-vd-aardweg
661: Improve solution. Deal with possible None values when getting th…
fdad8b2 
…e field.
@tim-vd-aardweg
661: Remove deprecated keyword dtmassbalance.
ae25d69
@tim-vd-aardweg
661: Updated default values for several keywords and updated some des…
3342ba4 
…criptions.
@tim-vd-aardweg
661: Set default value for sedimentmodelnr.
d4963d2
@tim-vd-aardweg
661: Updated testcase reference data.
925ec0b
@tim-vd-aardweg
661: Updated testcase to take Unions and Lists into account. This cur…
50b5f66 
…rently fails but should pass.
@tim-vd-aardweg
661: Updated implementation to take Unions and Lists into account.
791abcb
@tim-vd-aardweg
661: Add integration test that should pass but currently fails.
c6bd0a1
@tim-vd-aardweg
661: Added some more tests that should pass but currently fail.
5f223a7
@tim-vd-aardweg
661: Implemented potential solution.
c14bbc6
@tim-vd-aardweg
661: Improve solution. Deal with possible None values when getting th…
cb284ad 
…e field.
@tim-vd-aardweg
661: Remove deprecated keyword dtmassbalance.
a8a8d12
@tim-vd-aardweg
661: Updated default values for several keywords and updated some des…
2cb3c27 
…criptions.
@tim-vd-aardweg
661: Set default value for sedimentmodelnr.
1b1a432
@tim-vd-aardweg
661: Updated testcase reference data.
890c0ad
@tim-vd-aardweg
661: Updated testcase to take Unions and Lists into account. This cur…
bccf7bb 
…rently fails but should pass.
@tim-vd-aardweg
661: Updated implementation to take Unions and Lists into account.
0cbe2b0
@tim-vd-aardweg
Merge branch 'feat/661_Dont-write-empty-keywords' of https://github.c…
117f70e 
…om/Deltares/HYDROLIB-core into feat/661_Dont-write-empty-keywords
@tim-vd-aardweg
661: Remove obsolete keyword DtMassBalance from tests.
443f610
@tim-vd-aardweg
autoformat: isort & black
6062df1
@tim-vd-aardweg tim-vd-aardweg linked an issue Jul 4, 2024 that may be closed by this pull request
Don't write keywords with a None value to the files #661
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tim-vd-aardweg tim-vd-aardweg merged commit aa0af4c into main Jul 5, 2024
1 check passed
@tim-vd-aardweg tim-vd-aardweg deleted the feat/661_Dont-write-empty-keywords branch July 5, 2024 11:24
@veenstrajelmer veenstrajelmer mentioned this pull request Jul 5, 2024
Closed
@veenstrajelmer veenstrajelmer mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRVermeulenDeltares MRVermeulenDeltares MRVermeulenDeltares approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't write keywords with a None value to the files
2 participants
@tim-vd-aardweg @MRVermeulenDeltares