Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appsec lint #3021

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix appsec lint #3021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appsec/src/extension/commands_helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ static dd_result _dd_command_exec(dd_conn *nonnull conn,

// automatic cleanup of imsg on error branches
// set to NULL before calling _imsg_destroy
// NOLINTNEXTLINE(clang-analyzer-deadcode.DeadStores)
__attribute__((cleanup(_imsg_cleanup))) dd_imsg *nullable destroy_imsg =
&imsg;

Expand Down
3 changes: 2 additions & 1 deletion appsec/src/extension/network.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ dd_result dd_conn_sendv(dd_conn *nonnull conn, zend_llist *nonnull iovecs)
mlog_err(dd_log_info, "Error writing %zu bytes to helper", total);
efree(iovs);
return dd_network;
} else if (written == 0) {
}
if (written == 0) {
mlog(dd_log_info, "writev() call returned zero");
efree(iovs);
return dd_network;
Expand Down
Loading