Fix appsec lint #3021
Merged
Fix appsec lint #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3021 +/- ##
============================================
- Coverage 74.80% 72.93% -1.87%
Complexity 2781 2781
============================================
Files 112 139 +27
Lines 11017 15166 +4149
Branches 0 1022 +1022
============================================
+ Hits 8241 11062 +2821
- Misses 2776 3552 +776
- Partials 0 552 +552
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
estringana
force-pushed
the
estringana/fix-appsec-lint
branch
2 times, most recently
from
bc883bc to
56a7317
Compare
Anilm3
approved these changes
Jan 7, 2025
cataphract
reviewed
Jan 7, 2025
appsec/src/extension/network.c
Outdated
| @@ -218,7 +218,7 @@ dd_result dd_conn_sendv(dd_conn *nonnull conn, zend_llist *nonnull iovecs) | |||
| mlog_err(dd_log_info, "Error writing %zu bytes to helper", total); | |||
| efree(iovs); | |||
| return dd_network; | |||
| } else if (written == 0) { | |||
| } else if (written == 0) { // NOLINT | |||
There was a problem hiding this comment.
you can take out the else so that // NOLINT is not needed
estringana
force-pushed
the
estringana/fix-appsec-lint
branch
from
56a7317 to
19874c1
Compare
robertpi
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer checklist