-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synthetic stalls #4600
Open
tom-coward
wants to merge
8
commits into
Dash-Industry-Forum:development
Choose a base branch
from
bbc:badgers-upstream-552-synthetic-stalls
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add synthetic stalls #4600
tom-coward
wants to merge
8
commits into
Dash-Industry-Forum:development
from
bbc:badgers-upstream-552-synthetic-stalls
+201
−14
Commits on Oct 16, 2024
-
Add synthetic stalling (set playback rate to 0) when stream stalls
Co-authored-by: Joel Keers <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9398da1 - Browse repository at this point
Copy the full SHA 9398da1View commit details -
Add enableSyntheticStalls setting
Co-authored-by: Joel Keers <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ce89d9 - Browse repository at this point
Copy the full SHA 7ce89d9View commit details -
Add option to ignore ready state check for synthetic stalls
* also moves synthetic stall settings into syntheticStallEvents object Co-authored-by: Eirik Bjornerstedt <[email protected]> Co-authored-by: Joanne Monaghan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b811ed3 - Browse repository at this point
Copy the full SHA b811ed3View commit details -
Refactor setPlaybackRate to use waitForReadyState
* replaces listening for an canplay event manually, as has been done in other parts of VideoModel Co-authored-by: Eirik Bjornerstedt <[email protected]> Co-authored-by: Joanne Monaghan <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6e603ad - Browse repository at this point
Copy the full SHA 6e603adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fedc6d - Browse repository at this point
Copy the full SHA 5fedc6dView commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 606cd6b - Browse repository at this point
Copy the full SHA 606cd6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 735ad6a - Browse repository at this point
Copy the full SHA 735ad6aView commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c64fb45 - Browse repository at this point
Copy the full SHA c64fb45View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.