Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces optional (behind a setting defaulted off) synthetic stall functionality, which ensures all playback stops if one stream source buffer runs empty and stalls.
On a stall (
setStallState()
call inVideoModel
), if synthetic stall events are enabled once the video element is in a ready state we will:waiting
eventOnce a stall ends and the video element is in a ready state we will:
playing
eventWe found that some devices can break when the playback rate is set to 0 when a media buffer is empty, so will by default only perform synthetic stalls when the video element is in ready state
HAS_FUTURE_DATA
or higher; this can be overridden by setting theignoreReadyState
setting, which will cause synthetic stalls to occur regardless of the video element's ready state.As general housekeeping we've also switched
VideoModel.setPlaybackRate()
to use the sharedwaitForReadyState()
method.