Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Update deprecated class join-instruction-container to steps section to make it functional #122

Merged
merged 1 commit into from
Jul 10, 2024
+3 −14
Merged

Fix : Update deprecated class join-instruction-container to steps section to make it functional #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class Header extends HTMLElement {
<div class="buttons-container">
<ds-button-link
href="#join-instruction-container"
href="#steps-section"
size="small"
variant="ghost"
>참여방법 안내</ds-button-link
Expand Down
15 changes: 2 additions & 13 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,6 @@
place-content: center;
place-items: center;
}

#join-instruction-container {
margin-top: 15rem;
padding-bottom: 15rem;
border-bottom: 0.1rem solid #d3d3d3;
}

#join-instruction-container > span {
font-size: 5rem;
font-weight: medium;
}

/* 'review-card-list', 'instruction-card-list' style will be removed when the review card list, instruction card list component are created */
@media only screen and (min-width: 768px) {
Expand Down Expand Up @@ -211,7 +200,7 @@
slot="button"
size="big"
variant="ghost"
href="#join-instructions"
href="#steps-section"
>
참여방법 안내
</ds-button-link>
Expand Down Expand Up @@ -270,7 +259,7 @@
</div>
</div>

<ds-steps-section>
<ds-steps-section id="steps-section">
<ds-hero>스터디 참여방법</ds-hero>
<ds-step-list>
<ds-step step="1" iconSrc="images/icon_step1.png">
Expand Down