Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Update deprecated class join-instruction-container to steps section to make it functional #122

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

SamTheKorean
Copy link
Contributor

@SamTheKorean SamTheKorean commented Jul 10, 2024

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@SamTheKorean SamTheKorean requested a review from a team as a code owner July 10, 2024 16:31
@SamTheKorean SamTheKorean linked an issue Jul 10, 2024 that may be closed by this pull request
@sounmind sounmind changed the title FIx : Update deprecated class join-instruction-container to steps section to make it functional Fix : Update deprecated class join-instruction-container to steps section to make it functional Jul 10, 2024
@sounmind
Copy link
Collaborator

나중에는 @SamTheKorean 충돌 해결을 위해 merge commit 생성은 자제하시고,
로컬에서 리베이스한 후에 force push하면 불필요한 merge commit이 생기지 않아서 좋을 것 같아요~

@SamTheKorean
Copy link
Contributor Author

히스토리 정리하고 다시 force push 했습니다! 피드백 감사합니다!

@SamTheKorean SamTheKorean merged commit 99fd38e into main Jul 10, 2024
@SamTheKorean SamTheKorean deleted the sam/121 branch July 10, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join instruction button deprecated
2 participants