Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make definitionID mandatory for API Integration calls #70

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

rlucha-crowdstrike
Copy link
Collaborator

@rlucha-crowdstrike rlucha-crowdstrike commented Oct 22, 2024

Changes the type and removes the fallback mechanism of falcon.apiIntegration() calls to make definitionID required.

const apiIntegration = falcon.apiIntegration({
  operationId: 'Get Pokemon',
});

Becomes:

const apiIntegration = falcon.apiIntegration({
  definitionId: 'API Integration ID',
  operationId: 'Get Pokemon',
});

I don't consider this a breaking change due to this behaviour already being the case in the BE contract, apps using the first method will not work currently; this change plus the relevant documentation changes will the reason why explicit.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 0550a4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/foundry-js Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rlucha-crowdstrike rlucha-crowdstrike merged commit f312798 into main Oct 23, 2024
1 check passed
@rlucha-crowdstrike rlucha-crowdstrike deleted the rlucha/mandatory-definitionID branch October 23, 2024 10:21
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants