Merge pull request #70 from CrowdStrike/rlucha/mandatory-definitionID

Make definitionID mandatory for API Integration calls
CrowdStrike · Oct 23, 2024 · f312798 · f312798
2 parents 53b3189 + 0550a4e
commit f312798
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/mighty-tigers-sing.md b/.changeset/mighty-tigers-sing.md
@@ -0,0 +1,5 @@
+---
+'@crowdstrike/foundry-js': minor
+---
+
+Enforce mandatory definitionID for API Integration calls
diff --git a/src/api.ts b/src/api.ts
@@ -184,7 +184,7 @@ export default class FalconApi<DATA extends LocalData = LocalData> {
     operationId,
   }: {
     operationId: string;
-    definitionId?: string;
+    definitionId: string;
   }) {
     assertConnection(this);
 
@@ -194,7 +194,7 @@ export default class FalconApi<DATA extends LocalData = LocalData> {
 
     const apiIntegration = new ApiIntegration(this, {
       operationId,
-      definitionId: definitionId ?? this.data?.app.id,
+      definitionId: definitionId,
     });
 
     this.apiIntegrations.push(apiIntegration);