Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bump ibc-go version to 9.0.2 #2095

Merged
merged 3 commits into from
Jan 20, 2025
Merged

feat: Bump ibc-go version to 9.0.2 #2095

merged 3 commits into from
Jan 20, 2025

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird marked this pull request as ready for review January 17, 2025 08:12
@kulikthebird kulikthebird requested review from pinosu and chipshort and removed request for pinosu January 17, 2025 08:12
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.

Project coverage is 42.99%. Comparing base (939a837) to head (4523ae3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
tests/ibctesting/endpoint.go 0.00% 13 Missing ⚠️
tests/ibctesting/chain.go 0.00% 7 Missing ⚠️
tests/ibctesting/event_utils.go 0.00% 1 Missing ⚠️
x/wasm/ibc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
- Coverage   42.99%   42.99%   -0.01%     
==========================================
  Files          85       85              
  Lines       11601    11608       +7     
==========================================
+ Hits         4988     4991       +3     
- Misses       6166     6170       +4     
  Partials      447      447
Files with missing lines Coverage Δ
app/ante.go 63.63% <ø> (ø)
app/app.go 86.05% <100.00%> (+0.07%) ⬆️
app/test_support.go 0.00% <ø> (ø)
tests/ibctesting/coordinator.go 0.00% <ø> (ø)
tests/ibctesting/events.go 0.00% <ø> (ø)
tests/ibctesting/path.go 0.00% <ø> (ø)
tests/ibctesting/wasm.go 0.00% <ø> (ø)
x/wasm/keeper/handler_plugin.go 72.34% <ø> (ø)
x/wasm/keeper/handler_plugin_encoders.go 79.41% <ø> (ø)
x/wasm/keeper/ibc.go 77.77% <ø> (ø)
... and 9 more

chipshort
chipshort reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

app/app.go Outdated Show resolved Hide resolved
cmd/wasmd/root.go Show resolved Hide resolved
tests/e2e/ibc_callbacks_test.go Show resolved Hide resolved
x/wasm/ibc.go Show resolved Hide resolved
tests/ibctesting/chain.go Outdated Show resolved Hide resolved
chipshort
chipshort reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment and then we can merge IMHO

tests/ibctesting/endpoint.go Outdated Show resolved Hide resolved
tests/ibctesting/endpoint.go Show resolved Hide resolved
chipshort
chipshort approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird merged commit 219453c into main Jan 20, 2025
18 of 19 checks passed
@kulikthebird kulikthebird deleted the tkulik/bump_ibc_v9 branch January 20, 2025 17:27
@kulikthebird kulikthebird mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

@pinosu pinosu Awaiting requested review from pinosu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulikthebird @chipshort