Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: ibc v9 #2050

Closed
wants to merge 10 commits into from
Closed

deps: ibc v9 #2050

wants to merge 10 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 4, 2024

No description provided.

app/app.go Fixed Show fixed Hide fixed
This was referenced Dec 4, 2024
Comment on lines +60 to +64
for _, chain := range chains {
if err := chain.VerifyIBCModules(); err != nil {
t.Fatalf("failed to verify IBC modules for chain %s: %v", chain.ChainID, err)
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning test

Iteration over map may be a possible source of non-determinism
@faddat
Copy link
Contributor Author

faddat commented Dec 9, 2024

this PR not looking so hot. If anyone has advice, I am all ears.

@kulikthebird
Copy link
Contributor

The ibc-go module was updated here: #2095 and the ibc tests were refactored in a follow up PR here: #2097. I'm closing this PR as its main reason was to bump ibc-go. If there are some other changes here that you find relevant, please open a new PR on top of the current main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants