CLXP-174 Create new LP banner & replace CM Massive battle Quick access card on CM dashboard #2896
Conversation
…s card on CM dashboard
HuyIT9898
force-pushed
the
clxp-174
branch
3 times, most recently
from
3f54bb0
to
dd296f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2896 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 412 413 +1
Lines 6427 6431 +4
Branches 438 438
=======================================
+ Hits 5992 5996 +4
Misses 354 354
Partials 81 81
Continue to review full report in Codecov by Sentry.
|
| buttonLabel: 'Try Learning priorities', | ||
| onClick: () => console.log('click'), | ||
| image: | ||
| 'https://s3-alpha-sig.figma.com/img/4c6f/87c0/99896b9146631494f8dea4f523e3cdff?Expires=1731888000&Key-Pair-Id=APKAQ4GOSFWCVNEHN3O4&Signature=HvkcSCRSjz7RvLzB8D0HWNhuk7NUXFZSwLjBKmXxf5NPt-UCVf3wY9VUq~-bESu59PMJJVOcsdE-2h60AY65uswm-yk1yq2fd2dGvkeSXopK0YpqH-XLzdWo8FqHXVwSvB5RQlmA1KDHj1ERZjZJNijo2qXTE3eF71ksXxDm1g3c3XZgdD9TFfy8p9lLqKSBRpvway8bv7QNEcvuN-Q63-OR3EHHiftrZ-pOn0m2GFbuqIv3el-k3Zo60ZNINVeMjYkwN4~BG6PifpZdPWG9D3UenP12XNhPVCA3UJ7H1~ZTzu7q8jRG~h6TywD8S7sgowbtoQYoL5DE21bOxg0Ztg__' |
There was a problem hiding this comment.
Actually, the image I sent you to upload on s3 is unusable as it has a transparent background (i must have messed up the export 😆), and found out we can use correct image with this link. Can we keep it this way? Or we have to upload it to our s3 to use?
| import ButtonLink from '../../atom/button-link'; | ||
| import style from './style.css'; | ||
|
|
||
| const Go1BaseBanner = props => { |
There was a problem hiding this comment.
Not sure about the name.
Would rather use Coorpmanager as a prefix: CoorpmanagerBaseBanner
| @@ -0,0 +1,11 @@ | |||
| export default { | |||
There was a problem hiding this comment.
Can you put the existing banner as a fixture? go1-catalog
There was a problem hiding this comment.
The existing banner is a component name go1-banner. The styling was so different that I think I would better to create a new base banner
https://coorpacademy.github.io/components/components/?path=/story/molecule-go1banner--default
Purpose: Create new LP banner & replace CM Massive battle Quick access card on CM dashboard
review app: https://6628d2e0fd4aa63f3be2e1ab-gpnhtbdzfn.chromatic.com/?path=/story/template-backoffice-brandupdate--home