Skip to content

Commit

Permalink
resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Huy Nguyen authored and Huy Nguyen committed Nov 7, 2024
1 parent fb4458f commit 98d7a08
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import ButtonLink from '../../atom/button-link';
import style from './style.css';

const Go1BaseBanner = props => {
const CoorpmanagerBaseBanner = props => {
const {image, title, subTitle, buttonLabel, onClick} = props;

return (
Expand Down Expand Up @@ -42,12 +42,12 @@ const Go1BaseBanner = props => {
);
};

Go1BaseBanner.propTypes = {
CoorpmanagerBaseBanner.propTypes = {
image: PropTypes.string,
title: PropTypes.string,
subTitle: PropTypes.string,
buttonLabel: PropTypes.string,
onClick: PropTypes.func
};

export default Go1BaseBanner;
export default CoorpmanagerBaseBanner;
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
height: 266px;
right: 32px;
top: 32px;
box-shadow: 0px 4px 84px 0px rgba(0, 0, 0, 0.07);
border-radius: 8px;
}

@media (max-width: 1040px) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export default {
props: {
title: 'Learning Priorities, <br/> Focus on What Matters Most',
subTitle:
'Spotlight essential skills and direct learners to the most impactful training, <br/> optimizing their growth and enhancing your learning strategy.',
'Spotlight essential skills and direct learners to the most impactful training, optimizing their growth and enhancing your learning strategy.',
buttonLabel: 'Try Learning priorities',
onClick: () => console.log('click'),
image:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from 'react';
import PropTypes from 'prop-types';
import Title from '../../atom/title';
import QuickAccessCardGroup from '../../molecule/quick-access-cards-group';
import Go1BaseBanner from '../../molecule/go1-base-banner';
import CoorpmanagerBaseBanner from '../../molecule/coorpmanager-bas-banner';
import style from './style.css';

const Dashboard = props => {
Expand All @@ -12,7 +12,7 @@ const Dashboard = props => {
<div>
<Title {...header} type={'page'} />
</div>
{banner ? <Go1BaseBanner {...banner} /> : null}
{banner ? <CoorpmanagerBaseBanner {...banner} /> : null}
<div className={style.sectionWrapper}>
<Title title={quickAccessCards.title} type={'form-group'} />
<div className={style.cardsWrapper}>
Expand All @@ -32,7 +32,7 @@ Dashboard.propTypes = {
title: PropTypes.string,
cards: PropTypes.shape(QuickAccessCardGroup.propTypes)
}),
banner: PropTypes.shape(Go1BaseBanner.propTypes)
banner: PropTypes.shape(CoorpmanagerBaseBanner.propTypes)
};

export default Dashboard;
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {defaultsDeep} from 'lodash/fp';
import Go1BaseBanner from '../../../../../molecule/go1-base-banner/test/fixtures/default';
import Go1BaseBanner from '../../../../../molecule/coorpmanager-bas-banner/test/fixtures/default';
import Default, {items} from './default';

const {props} = Default;
Expand Down

0 comments on commit 98d7a08

Please sign in to comment.