Porting Loading #242
Porting Loading #242
Conversation
|
|
||
| <Grid> | ||
| <controls:Loading IsLoading="{x:Bind LoadingState, Mode=OneWay}"> | ||
| <controls:Loading.Content> |
There was a problem hiding this comment.
The extra layer here shouldn't be needed, Content should be set by default.
| mc:Ignorable="d"> | ||
|
|
||
| <Grid> | ||
| <controls:Loading IsLoading="{x:Bind LoadingState, Mode=OneWay}"> |
There was a problem hiding this comment.
Maybe as another sample we can combine with the MVVM Toolkit and the Converter Task helper we have for the TaskResultConverter so that the loading command/task thing auto sets the thing to true? (Just have a dummy delay for like 5 seconds?)
|
@niels9001 actually was just thinking, is there anything the We could adapt the MVVM Toolkit sample: https://github.com/CommunityToolkit/MVVM-Samples/blob/master/samples/MvvmSampleUwp/Views/AsyncRelayCommandPage.xaml And show another sample with SwitchPresenter bound to the Task Status with three states:
Seems like would be more useful maybe? Would need to have maybe buttons/commands in the sample to simulate the operations to showcase each state? @Arlodotexe we're still missing those in the sample source generator, eh? |
|
I'd love to see this request complete. Not having the Loading control currently is blocking my upgrade. I will take a look at the |
|
We'e discussed this with the Toolkit team, and decided to not go through with this port in favor of #285 |
This PR ports over the Loading control.
Tested on UWP, WASDK
@Arlodotexe Sample doesn't do anything on WASM.. but not getting any errors either, do you see what's going on?
Closes: #92