Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Brazilian Portuguese Curriculum #210

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Adding Brazilian Portuguese Curriculum #210

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 19, 2018

Adding the Brazilian Portuguese Curriculum, so other countries can follow the translated material.

@vsmart
Copy link
Member

vsmart commented Feb 19, 2018

👋 @localhostpedro Thanks so much for the translating work! 🙇‍♀️ Do you have the Portugese version deployed somewhere? If yes, you could link to that. If not, could you link to the direct branch in the fork like the Spanish version does? I couldn't find the portugese version in the forked repo on first glance.

@ghost
Copy link
Author

ghost commented Feb 19, 2018

@vsmart Yes I do have the Portuguese version in a bunch of Markdown files, and I'm still putting them together. One thing that I'd like to know is ,should I keep the ptbr version in my repo or reorganize to fit under the may curriculum , so everyone can fork from the central ClojureBridge repo ?

@ghost
Copy link
Author

ghost commented Feb 19, 2018

Like, creating language filters, for example, in the index.md of the curriculum, i'd like to change the actual content to:

# Choose the language:

*  [English](/link_to_this_version_translated)
*  [Spanish](/link_to_this_version_translated)
*  [Portuguese](/link_to_this_version_translated)
*  [Other Language](/link_to_this_version_translated)

And fit all the translated markdown files under a folder, lets say "languages", in the root of the curriculum, and inside the languages folder, another folder containing the curriculum in each language.

@vsmart
Copy link
Member

vsmart commented Feb 19, 2018

Ok, let's hold off on adding the link here until you have put the portugese version together in one place.

As for multi-language filters, could you open a separate ticket to start this discussion?

@ghost
Copy link
Author

ghost commented Feb 19, 2018

ok, I'm putting the files together.

About the filters, I've opened this issue #211

@dijonkitchen
Copy link
Contributor

Looks like the original poster's account has been deleted and the link to the new curriculum is dead. Unfortunately, it looks like we'll have to close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants