Feature/toggle button directive #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukavdplas
added
frontend
Closed
JeltevanBoheemen
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that all toggle buttons set
aria-pressedappropriately. (Toggle buttons are buttons that express an on/off state with visual styling; aria-pressed makes that perceivable for assistive technologies.)I added a
ToggleButtonDirectiveto set the CSS class andaria-pressedin one go.In some cases, I also addressed some additional issues:
<a>being used as a buttonaria-labelbeing used on the icon container in the button, rather than the button itself. As I recently found out, aria-label can be used quite widely, but not everywhere (see aria-label specification).