Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle/radio buttons #1604

Closed
lukavdplas opened this issue Jun 13, 2024 · 0 comments · Fixed by #1645
Closed

Toggle/radio buttons #1604

lukavdplas opened this issue Jun 13, 2024 · 0 comments · Fixed by #1645
Labels
accessibility improvements in web accessibility frontend changes to the angular frontend

Comments

@lukavdplas
Copy link
Contributor

This issue concerns:

  • The long format / wide format buttons in the FreqTableComponent
  • The graph / table buttons in the VisualizationComponent and WordModelsComponent.

The current state of these buttons is only conveyed through colours. They could set aria-pressed to indicate their state.

In both of these cases, however, the buttons are not independent toggles but a radio group (see also this radio group pattern guide), so that would be more appropriate.

Setting aria-pressed is trivial and achieves basic usability, implementing the radio group is a bit more work.

@lukavdplas lukavdplas added frontend changes to the angular frontend accessibility improvements in web accessibility labels Jun 13, 2024
@lukavdplas lukavdplas linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility improvements in web accessibility frontend changes to the angular frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant