Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Glosses UI Touch Up #158

Merged
merged 20 commits into from
Jan 24, 2024
Merged

Manage Glosses UI Touch Up #158

merged 20 commits into from
Jan 24, 2024

Conversation

thehabes
Copy link
Member

No description provided.

@thehabes
starting to do the productive mess around. Bring in updates from othe…
0c2a241 
…r templates, get [unlabeled] entries to work in the managed list. Introduce checkboxes for flags to filter by, add status into filterable list item logic.
@thehabes
filterable by public and unlabeled status. One is detectable syncrono…
c433ac6 
…usly, but the other is asyncronous. These two are good pilot statuses to design around, as they represent the differing necessities for detecting and adding status attributes to Glosses in the lists.
@thehabes
ha. neat. status filters functional and cooperative with the title fi…
f9e73a7 
…lter.
@thehabes
As I suspected, coming into this with ?gog-filter is difficult for st…
f4dd3fe 
…atuses that require asyncronous behavior to figure out. I don't think we need to be passing the filter around from this management page, so I am disabling it for now.
@thehabes
The 'match on incipit' textual filter will need to include the status…
d2e3c06 
… filters. They don't quite work together yet, but to fully code that is out of scope of this touch up. I'll leave the pieces behind, but hide the ones we aren't using now.
@thehabes
I don't think we will use or support gog-filter on this page
b2b35a5
@thehabes thehabes self-assigned this Dec 18, 2023
@thehabes thehabes linked an issue Dec 18, 2023 that may be closed by this pull request
Manage Glosses UI Touch Up #154
Closed
@thehabes
After looking into various options, this zen one is good. Show 'publi…
f854e4b 
…c' status next to Gloss label. Clicking gloss label opens a modal with the management options.
@thehabes
nice prototype
8fd4a2f
@thehabes
A bit of a redesign to make it more like the 'Glosses' page.
5464e50
@thehabes
A modal. Now we need to code in the new pagination required as manage…
84d6e51 
…rs do things.
@thehabes
Gloss modal in the Gloss Management interface as a custom element. It…
5462730 
… has self contained functionality and is better organized this way.
@thehabes
Bring the published status indicator into the modal
95fa88f
@thehabes
Finishing up. Stay in scope. removeFromCollectionAndDelete for Glosse…
6320f24 
…s is no longer available because it is not coded correctly for the new Gloss data structure.
@thehabes
It's all there. Do a document and cleanup round.
b76948f
@thehabes
Documentation and cleanup for PR
75cc03a
@thehabes thehabes marked this pull request as ready for review December 20, 2023 20:45
@thehabes thehabes requested a review from cubap as a code owner December 20, 2023 20:45
@thehabes
Copy link
Member Author

thehabes commented Dec 20, 2023 •
edited
Loading

@cubap Please review this when you are back in action. Do some whitespace commit to ensure this branch is deployed at https://glossing-dev.rerum.io

This scope went a bit beyond just a touch up.

  • The UI has a path for "statuses" and "status filters" now, but they are hidden until we get them right. We need to recode the filters to know about each other and work together ($AND or $OR)
  • Gloss deletion has been placed 'under construction' and is not available to users. We need to rewrite it to accommodate the new Gloss data structure. For example, the delete functionality doesn't know it needs to delete Witnesses when deleting a Gloss.
  • The 'quick actions' in the Management UI are no longer available. All actions are an extra click away because they have moved into a modal, and this is the new management mechanic.

Note the "for when we test" tricks are active and properties.json is staged for dev. Make sure to get rid of the "for when we test" tricks before you merge with main. Remember to update properties.json on main after you merge. Do not update properties.json on this branch because that will make glossing-dev use prod data.

cubap
cubap approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@cubap cubap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS could be touched up, but the flow is much cleaner.

@cubap cubap merged commit e134811 into main Jan 24, 2024
3 checks passed
@cubap cubap deleted the 154-manage-glosses-touch-up branch January 24, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubap cubap cubap approved these changes

Assignees

@thehabes thehabes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manage Glosses UI Touch Up
2 participants
@thehabes @cubap