Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete publications #1497

Merged
merged 7 commits into from
Oct 13, 2020
Merged

Delete publications #1497

merged 7 commits into from
Oct 13, 2020

Conversation

Jesus89
Copy link
Member

@Jesus89 Jesus89 commented Jan 17, 2020

Related to #1496

@elenatorro
Copy link
Contributor

elenatorro commented Jan 17, 2020 •
edited
Loading

Could you update the migration guide? :) Here https://github.com/CartoDB/cartoframes/blob/develop/docs/developers/migrations/v1.0.0.md#Delete

Nevermind! I saw it's just for the kuviz 👍

@elenatorro elenatorro self-requested a review January 17, 2020 12:04
elenatorro
elenatorro suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@elenatorro elenatorro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace the deleted tests?

@josemazo josemazo removed the blocked label Jul 9, 2020
@josemazo josemazo mentioned this pull request Jul 9, 2020
Open
@josemazo
Copy link
Contributor

josemazo commented Jul 9, 2020

CH story ch78723

antoniocarlon
antoniocarlon approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@antoniocarlon antoniocarlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and merged develop 🚀

@antoniocarlon antoniocarlon merged commit 53bed16 into develop Oct 13, 2020
@antoniocarlon antoniocarlon deleted the delete-publications branch October 13, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenatorro elenatorro elenatorro requested changes

@antoniocarlon antoniocarlon antoniocarlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jesus89 @elenatorro @josemazo @antoniocarlon