-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting publications in CARTOframes #1496
Comments
Said that, with the solution we have already provided, we are giving the user the value we wanted so I would go with this approach. |
OK, perfect. I agree with adding the methods in |
PR #1497 |
The way publications are deleted now is incomplete and not very useful. When a map is published, you can use the instance of the map to call
delete_publication
and it removed the latest publication of the map. However, if you publish the same map instance twice with different names, the first publication is lost andmap.delete_publication()
removes the second one which is the latest, but not the first.There is also a static method
Map.all_publications
to get all the publications, which provides a dict containing the id, url, name, and privacy of the publications. But you can not use this since there is no static methodMap.delete_publication(name)
.Proposal
My proposal is to remove the instance method
delete_publication()
and add aMap.delete_publication(name)
method. This can be done changing only CF. I have implemented a PoC in this branch:delete-publications
.cc @cmongut @oleurud @alasarr
The text was updated successfully, but these errors were encountered: