Mesh 3 - Triangulation IO and Save and load C3t3 features #7821
+797
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triangulation_3 file_input now uses the new IO
lrineau
requested changes
Oct 30, 2023
There was a problem hiding this comment.
For the moment, the testsuite of Triangulation_3 fails. I tried on my machine:
ctest --test-dir build/RelWithDebInfo -L Triangulation_3 -j12
and the results was:
82% tests passed, 16 tests failed out of 89
Label Time Summary:
CGAL_build_system = 24.20 sec*proc (2 tests)
Triangulation_3_Demo = 20.06 sec*proc (1 test)
Triangulation_3_Examples = 317.92 sec*proc (42 tests)
Triangulation_3_Tests = 366.77 sec*proc (44 tests)
Total Test time (real) = 89.57 sec
The following tests FAILED:
2134 - compilation of simple_triangulation_3 (Failed)
2135 - execution of simple_triangulation_3 (Not Run)
5041 - compilation of test_delaunay_3 (Failed)
5042 - execution of test_delaunay_3 (Not Run)
5045 - compilation of test_delaunay_hierarchy_3 (Failed)
5046 - execution of test_delaunay_hierarchy_3 (Not Run)
5047 - compilation of test_delaunay_hierarchy_3_old (Failed)
5048 - execution of test_delaunay_hierarchy_3_old (Not Run)
5051 - compilation of test_regular_as_delaunay_3 (Failed)
5052 - execution of test_regular_as_delaunay_3 (Not Run)
5073 - compilation of test_triangulation_3 (Failed)
5074 - execution of test_triangulation_3 (Not Run)
5075 - compilation of test_io_triangulation_3 (Failed)
5076 - execution of test_io_triangulation_3 (Not Run)
5077 - compilation of test_triangulation_serialization_3 (Failed)
5078 - execution of test_triangulation_serialization_3 (Not Run)
sloriot
reviewed
Nov 2, 2023
sloriot
added
Tests failing
Batch_1
sloriot
reviewed
Nov 2, 2023
Removed unused type aliases + Removed the need for default convertor
maybe Fix license
afabri
reviewed
Nov 29, 2023
|
Funny thing is that only https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-177/SMDS_3/TestReport_lrineau_Fedora-32.gz does not have the runtime error. |
…preserve-features-aclement
the number of cells was not updated due to the call to rescan_after_load_of_triangulation not being done.
|
@janetournois @sloriot This PR is ready to be reviewed and tested. |
Yes, there is a test that is not performed on 32 bits architectures. |
|
@ange-clement could you please fix the merge conflict? |
…preserve-features-aclement
|
Test failing in 6.0-Ic-305 See here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Enable writing and reading of 1D features (edges) of
Mesh_complex_3_in_triangulation_3.The
Triangulation_3writing and loading have been moved toCGAL::IO::export_triangulation_3andCGAL::IO::import_triangulation_3Tasks:
Triangulation_3writing and loading (operator<</>>)Triangulation_3::file_inputuse the writing and loading (remove duplicated code)Release Management