Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3: Save/load c3t3 objects correctly #2359

Open
lrineau opened this issue Aug 22, 2017 · 6 comments · May be fixed by #5151 or #7821
Open

Mesh_3: Save/load c3t3 objects correctly #2359

lrineau opened this issue Aug 22, 2017 · 6 comments · May be fixed by #5151 or #7821

Comments

@lrineau
Copy link
Member

lrineau commented Aug 22, 2017

Issue Details

For the moment, the I/O of C3t3 objects only save/load the information of the TDS_3, and the I/O of C3t3::Triangulation::Vertex and C3t3::Triangulation::Cell ensures that most of the information of the C3t3 is saved and restored.

But a C3t3 object has data that is not stored in the TDS. Some of it can be retrieved after a load by a call to the undocumented method c3t3.rescan_after_load_of_triangulation(), but the c3t3.is_in_complex(Edge) information cannot be retrieved. It should be stored in the file, and loaded from it.

This issue will require a solution to #861 first.

Environment

  • CGAL version: CGAL-4.11

Cc: @sloriot

@lrineau lrineau added this to the 4.12-beta milestone Aug 22, 2017
@lrineau lrineau modified the milestones: 4.12-beta, 4.13-beta Feb 13, 2018
@lrineau lrineau modified the milestones: 4.13-beta, 4.14-beta Aug 1, 2018
@lrineau lrineau modified the milestones: 4.14-beta, 4.14 Mar 4, 2019
@lrineau lrineau modified the milestones: 4.14-beta2, CGAL-4.14 Mar 13, 2019
@sloriot sloriot modified the milestones: 4.14, 5.0-beta Apr 1, 2019
@sloriot
Copy link
Member

sloriot commented Apr 1, 2019

Shall this issue be handled by @maxGimeno ?

@lrineau
Copy link
Member Author

lrineau commented Apr 2, 2019

The issue pointed by #861 is a real blocker for this one.

@sloriot
Copy link
Member

sloriot commented Apr 2, 2019

To me it seems this issue has a proposal solution :)

@maxGimeno
Copy link
Contributor

Indeed, you seem to have agreed with Sebastien's proposal to add new functions to complete the IO. I could probably take care of both issues.

@maxGimeno maxGimeno linked a pull request Nov 9, 2020 that will close this issue
@lrineau lrineau modified the milestones: 5.2-beta, 5.2-beta2 Nov 18, 2020
@MaelRL MaelRL modified the milestones: 5.2-beta2, 5.3-beta Dec 2, 2020
@lrineau lrineau modified the milestones: 5.3-beta, 5.3-beta2 Jun 4, 2021
@lrineau lrineau modified the milestones: 5.3-beta2, 5.3 Jun 29, 2021
@lrineau lrineau modified the milestones: 5.3, 5.3.1 Jul 7, 2021
@lrineau lrineau modified the milestones: 5.3.1, 5.5-beta1 Sep 29, 2021
@sloriot sloriot modified the milestones: 5.5-beta, 5.6-beta Apr 12, 2022
@sloriot sloriot modified the milestones: 5.6-beta, 6.0-beta May 11, 2023
@janetournois
Copy link
Member

related to issue #7780

@ange-clement ange-clement linked a pull request Oct 23, 2023 that will close this issue
3 tasks
@janetournois
Copy link
Member

PR #7821 solves this issue

@lrineau lrineau linked a pull request Oct 30, 2023 that will close this issue
3 tasks
@sloriot sloriot modified the milestones: 6.0-beta, 6.1-beta Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment