-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JiT include update #1696
JiT include update #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably this means we could delete code related to actually finding those headers and reading them. At a glance, this looks good and presumably reduces the volume of output when using CEED_DEBUG=1
.
I'm guessing the OpenCL online compiler has similar functionality, but we'll need to check that for the SYCL backends. |
6561528
to
db889fb
Compare
8b077cc
to
ae8472b
Compare
40a2154
to
4aeb1d9
Compare
Need to run full suite tomorrow, but seems fine with Ratel (should be) |
e979080
to
b5030a2
Compare
Ratel is happy. Noether looks happy. I say we merge this and do further improvements as follow-up. |
Hello, I checked out your branch and tested it, but the error persists: |
This remains really difficult for me to fully understand without the actual code generating the issue |
Guessing here, if you are using a local include |
Ah so |
Yes, at this time we're still interpreting |
Changing to |
Do you plan to change the behavior of |
Not in this PR, no. |
05c4fc1
to
fb6f31a
Compare
fb6f31a
to
9c25dd6
Compare
* doc: Update release notes based on #1696 Co-authored-by: Jeremy L Thompson <[email protected]>
Update JiT to
-I
all the JiT directories set on the Ceed.Note: Most of the changes are repeated ripple effects from the core changes it
ceed-[cuda,hip]-compile.h
.Allow searching of dirs set with CeedAddJitSourceRoot for #include <foo.h>
Add CEED_RUNNING_JIT_PASS to guard files that cannot be included for JiT (math.h or std*.h)
Prefer ceed/types.h over ceed.h in QF source
Redirect ceed.h to ceed/types.h over ceed/ceed.h when CEED_RUNNING_JIT_PASS is set
Use include statements instead of loading string buffers for JiT
Ok, here's a rough prototype of an idea @jedbrown. This allows#include <foo.h>
(stripping out#include <std*.h>
) and would add all JiT dirs as-I/include/this/dir
flags to the CUDA/HIP JiT compilers.Very rough and not rigorously tested but seems to work locally with hacky manual testing.