-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spectre.console lib to manage ANSI escape code #497
Conversation
Looks nice, can you verify things still function with a native AOT build build it similar to how we do it in CI (AFAIK PRs don't generate artifacts for u test with) bmx/.github/workflows/publish.yml Lines 97 to 102 in 8451532
something like
Verify that things still work with that build, not expecting trouble here I think, since there is no trimming warnings / huge increase in binary size. |
Ran this command and tested with its build. It looked fine to me. However, it had some trimming warnings just like from CI:
Is this something to worry about? |
That is a known warning with our choice of puppeter sharp (and present prior to this PR), doesn't look relevant to the new lib you are introducing. What we do need to verify is that the coloured text still prints as expected when invoking the native AoT build of BMX which you just built. === It isn't likely to be an issue in this particular case, but in the past for example we've had issues where the application works as expected when doing However later when we try the native build (which has had code trimming done as part of building for Native AoT) the application no longer functions etc.. Native AoT stuff has difficulty understanding code is actually used in some cases and isn't dead code that can be trimmed, so best to always check things are functional after introducing a new library. |
Thank you for the info! Just verified that the coloured text worked as expected with the Native AoT build, both when the |
2d7f2fb / #497 broke `bmx print` by writing all these message to stdout. Only the environment variable setting commands outputted by `bmx print` can go to stdout. All other messages should to stderr. https://desire2learn.atlassian.net/browse/VUL-628
Why
Avoid using hardcoded ANSI escape codes to make it more readable.
Ticket
VUL-424