Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write all informational messages to stderr #499

Merged
merged 1 commit into from
Jan 7, 2025
Merged

write all informational messages to stderr #499

merged 1 commit into from
Jan 7, 2025

Conversation

cfbao
Copy link
Member

@cfbao cfbao commented Jan 6, 2025 •
edited
Loading

2d7f2fb / #497 broke bmx print by writing all these message to stdout.

Only the environment variable setting commands outputted by bmx print can go to stdout. All other messages should to stderr.

https://desire2learn.atlassian.net/browse/VUL-628

@cfbao cfbao marked this pull request as ready for review January 6, 2025 20:32
@cfbao cfbao requested a review from a team as a code owner January 6, 2025 20:32
@cfbao cfbao requested review from boarnoah, scowing and gord5500 January 6, 2025 20:32
@cfbao cfbao merged commit ae2b49a into main Jan 7, 2025
9 checks passed
@cfbao cfbao deleted the stderr branch January 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gord5500 gord5500 gord5500 approved these changes

@boarnoah boarnoah Awaiting requested review from boarnoah boarnoah is a code owner automatically assigned from Brightspace/vulcan

@scowing scowing Awaiting requested review from scowing scowing is a code owner automatically assigned from Brightspace/vulcan

Assignees
No one assigned
Labels
language/csharp size/S A small PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfbao @gord5500