fix: split cookie rules #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
elsapet
force-pushed
the
fix/split-cookie-rules
branch
from
c615849 to
8d45783
Compare
elsapet
force-pushed
the
fix/split-cookie-rules
branch
from
204fcaf to
1293763
Compare
cfabianski
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits existing cookie rules so that CWE 1004 (HTTP Only flag) and CWE 614 (Secure flag) are represented by separate rules.
We keep the existing rule IDs for CWE-614 - so this is not a breaking change - and we create a new rule for CWE-1004.
The Java lang cookie rule has already been split into separate rules but the original rule remains, leaving us with 3 cookie rules for Java. We shall remove the original rule in the future, once Bearer/bearer#1486 has been addressed.Update: There is no duplication with the Java cookies - we have one (that we will split) that checks for httpOnly and secure set to False, and we have two additional rules - one that matches on the absence of httpOnly set to True and one that matches on the absence of secure set to True.
Closes #215
Checklist