Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rule_schema.jsonc #210

Closed
wants to merge 1 commit into from
Closed

Conversation

cfabianski
Copy link
Collaborator

Description

Ensure one and only cwe per rule

Checklist

  • I've added a snapshot that shows my rule works as expected.
  • My rule has adequate metadata to explain its use.
  • PR title follows Conventional Commits format

@cfabianski
Copy link
Collaborator Author

Let's merge this one once we have done the job to only have 1 CWE per rule

@gotbadger
Copy link
Contributor

@cfabianski Its at most 1 some might have zero

@cfabianski
Copy link
Collaborator Author

@cfabianski Its at most 1 some might have zero

I don't think that's correct. We should always have a CWE

@gotbadger
Copy link
Contributor

I was thinking of best practice type ones but looks like they can go under 693

@cfabianski
Copy link
Collaborator Author

Good to be merged once this is in #219

@gotbadger
Copy link
Contributor

@cfabianski FYI https://github.com/Bearer/bearer/blob/26d4d746d72f63d51f2ba144f5e7e08e360ca400/internal/commands/process/settings/ruleValidator.go#L13 rules need to get released before this can merge to main

@gotbadger
Copy link
Contributor

closed in favour of #296

@gotbadger gotbadger closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants