-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/signing-config-setup #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e if all signing properties are specified; adjust both 'CODE_SIGN_STYLE' and 'CODE_SIGN_IDENTITY'
…oject's signing setting as is
GMinucci
reviewed
Sep 26, 2023
arthurpalves
force-pushed
the
fix/signing-config-setup
branch
from
October 12, 2023 13:01
a2352da
to
2baebc7
Compare
dubeboy
reviewed
Oct 12, 2023
…ng configuration, thus enabling locally installed provisionings and certs
…d 'exportMethod' is provided
arthurpalves
force-pushed
the
fix/signing-config-setup
branch
from
October 19, 2023 11:53
2baebc7
to
25d8dcb
Compare
dubeboy
approved these changes
Oct 19, 2023
GMinucci
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
signing
configuration isnil
and, instead, maintains the project's signing settings as is (i.e.: in case of automatic signing)CODE_SIGN_STYLE
andCODE_SIGN_IDENTITY
updateSigningConfig
an optional step.matchURL
parameter in the signing configuration, thus enabling locally installed provisioning profiles and certsHow can it be tested
variants.yml
without asigning
configuration. This should no longer fail. Instead, it should setup everything but maintain the existing signing config in Xcode.variants.yml
(either global or variant's specific) and switch variants. This should now modify the project's signing config in Xcode.Task
resolves #214
resolves #215
Checklist:
make validation
locally with success