Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/signing-config-setup #225

Merged
merged 11 commits into from
Oct 19, 2023
Merged

fix/signing-config-setup #225

merged 11 commits into from
Oct 19, 2023

Conversation

arthurpalves
Copy link
Member

@arthurpalves arthurpalves commented Jun 13, 2023

What does this PR do

  • Removes the runtime error when signing configuration is nil and, instead, maintains the project's signing settings as is (i.e.: in case of automatic signing)
  • Adds/adjusts signing configuration when switching variants, not only during setup.
  • When adding/adjusting signing configuration also include CODE_SIGN_STYLE and CODE_SIGN_IDENTITY
  • Makes updateSigningConfig an optional step.
  • Removes the necessity to have a matchURL parameter in the signing configuration, thus enabling locally installed provisioning profiles and certs

How can it be tested

  1. Setup a new project using a variants.yml without a signing configuration. This should no longer fail. Instead, it should setup everything but maintain the existing signing config in Xcode.
  2. Add a signing configuration to your variants.yml (either global or variant's specific) and switch variants. This should now modify the project's signing config in Xcode.

Task

resolves #214
resolves #215

Checklist:

  • I ran make validation locally with success
  • I have not introduced new bugs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new errors

@arthurpalves arthurpalves requested a review from GMinucci June 13, 2023 12:15
@arthurpalves arthurpalves self-assigned this Jun 13, 2023
@arthurpalves arthurpalves requested a review from dubeboy June 13, 2023 12:28
@arthurpalves arthurpalves requested a review from GMinucci October 12, 2023 12:29
@arthurpalves arthurpalves force-pushed the fix/signing-config-setup branch from a2352da to 2baebc7 Compare October 12, 2023 13:01
@arthurpalves arthurpalves force-pushed the fix/signing-config-setup branch from 2baebc7 to 25d8dcb Compare October 19, 2023 11:53
@arthurpalves arthurpalves merged commit 2972d0c into develop Oct 19, 2023
5 checks passed
@arthurpalves arthurpalves deleted the fix/signing-config-setup branch October 19, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to signing configuration Some signing configurations not automatically set in Xcode 14
3 participants