ref: only update siging config if appropriate 'teamID', 'teamName' an…

…d 'exportMethod' is provided
Backbase · Oct 19, 2023 · 25d8dcb · 25d8dcb
1 parent fab1d10
commit 25d8dcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Sources/VariantsCore/Factory/iOS/XCConfigFactory.swift b/Sources/VariantsCore/Factory/iOS/XCConfigFactory.swift
@@ -179,7 +179,9 @@ class XCConfigFactory: XCFactory {
         guard
             let exportMethod = variant.signing?.exportMethod,
             let teamName = variant.signing?.teamName,
-            let teamID = variant.signing?.teamID
+            let teamID = variant.signing?.teamID,
+            !teamID.isEmpty,
+            !teamName.isEmpty
         else { return }
 
         let xcodeFactory = XcodeProjFactory()

diff --git a/Sources/VariantsCore/Factory/iOS/XcodeProjFactory.swift b/Sources/VariantsCore/Factory/iOS/XcodeProjFactory.swift
@@ -125,8 +125,7 @@ struct XcodeProjFactory {
             }
             try project.write(path: projectPath)
         } catch {
-            dump(error)
-            logger.logFatal("❌ ", item: "Unable to add files to Xcode project '\(projectPath)'")
+            logger.logFatal("❌ ", item: "Unable to add files to Xcode project '\(projectPath)', error: '\(error.localizedDescription)'")
         }
     }