-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes the default value to be of type list #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarfil
force-pushed
the
fix-support_list-nf
branch
2 times, most recently
from
September 24, 2024 07:51
f8c7a4f
to
013e714
Compare
qgerome
requested changes
Sep 25, 2024
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
September 25, 2024 08:35
013e714
to
d8822a3
Compare
Could you write tests for your changes ? |
nazarfil
force-pushed
the
fix-support_list-nf
branch
2 times, most recently
from
September 26, 2024 08:21
b76cdab
to
a68baaf
Compare
Closes HEXA-1037 : Default values for parameters set as "multiple" fails on run of the pipeline
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
September 26, 2024 08:28
a68baaf
to
1c8e6a2
Compare
Closes HEXA-1037: fixes list of parameters"
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
September 29, 2024 20:17
1b8d256
to
bfcfd5a
Compare
nazarfil
force-pushed
the
fix-support_list-nf
branch
3 times, most recently
from
September 30, 2024 07:50
8d62331
to
6117838
Compare
qgerome
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PipelineParameterSpecs can be removed
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
October 1, 2024 06:53
6a91d71
to
5e5ab17
Compare
qgerome
requested changes
Oct 1, 2024
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
October 1, 2024 15:45
5992c19
to
fd8543d
Compare
nazarfil
force-pushed
the
fix-support_list-nf
branch
from
October 1, 2024 16:08
fd8543d
to
4ddafcc
Compare
qgerome
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows choices to contain list as parameter
Checks if all items in list of default items are in choices