Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes the default value to be of type list #211

Merged
merged 8 commits into from
Oct 2, 2024
Merged

Conversation

nazarfil
Copy link
Contributor

Allows choices to contain list as parameter
Checks if all items in list of default items are in choices

@nazarfil nazarfil force-pushed the fix-support_list-nf branch 2 times, most recently from f8c7a4f to 013e714 Compare September 24, 2024 07:51
openhexa/sdk/pipelines/parameter.py Outdated Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
@qgerome
Copy link
Member

qgerome commented Sep 25, 2024

Could you write tests for your changes ?

@nazarfil nazarfil force-pushed the fix-support_list-nf branch 2 times, most recently from b76cdab to a68baaf Compare September 26, 2024 08:21
Closes HEXA-1037 : Default values for parameters set as "multiple" fails on run of the pipeline
Closes HEXA-1037: fixes list of parameters"
@nazarfil nazarfil force-pushed the fix-support_list-nf branch 3 times, most recently from 8d62331 to 6117838 Compare September 30, 2024 07:50
Copy link
Member

@qgerome qgerome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PipelineParameterSpecs can be removed

openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
openhexa/sdk/pipelines/runtime.py Outdated Show resolved Hide resolved
@nazarfil nazarfil merged commit 151e3af into main Oct 2, 2024
4 checks passed
@nazarfil nazarfil deleted the fix-support_list-nf branch October 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants