fixes: tests

Closes HEXA-1037: fixes list of parameters"
BLSQ · Sep 29, 2024 · bfcfd5a · bfcfd5a
1 parent e5e356c
commit bfcfd5a
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 5 deletions.
diff --git a/openhexa/sdk/pipelines/parameter.py b/openhexa/sdk/pipelines/parameter.py
@@ -431,7 +431,6 @@ def validate(self, value: typing.Any) -> typing.Any:
 
     def to_dict(self) -> dict[str, typing.Any]:
         """Return a dictionary representation of the Parameter instance."""
-        print(f"Multiple  : {self.required}, required: {self.required}")
         return {
             "code": self.code,
             "type": self.type.spec_type,

diff --git a/openhexa/sdk/pipelines/pipeline.py b/openhexa/sdk/pipelines/pipeline.py
@@ -173,6 +173,8 @@ def to_dict(self):
             "name": self.name,
             "parameters": [p.to_dict() for p in self.parameters],
             "timeout": self.timeout,
+            "function": self.function.__name__ if self.function else None,
+            "tasks": [t.__dict__ for t in self.tasks],
         }
 
     def _get_available_tasks(self) -> list[Task]:

diff --git a/tests/test_ast.py b/tests/test_ast.py
@@ -38,7 +38,8 @@ def test_pipeline_no_parameters(self):
                 )
             pipeline = get_pipeline(tmpdirname)
             self.assertEqual(
-                pipeline.to_dict(), {"code": "test", "name": "Test pipeline", "parameters": [], "timeout": None}
+                pipeline.to_dict(), {"code": "test", "name": "Test pipeline", "function": None,
+                                     "tasks": [], "parameters": [], "timeout": None}
             )
 
     def test_pipeline_with_args(self):
@@ -58,7 +59,8 @@ def test_pipeline_with_args(self):
                 )
             pipeline = get_pipeline(tmpdirname)
             self.assertEqual(
-                pipeline.to_dict(), {"code": "test", "name": "Test pipeline", "parameters": [], "timeout": None}
+                pipeline.to_dict(), {"code": "test", "function": None,
+                                     "tasks": [], "name": "Test pipeline", "parameters": [], "timeout": None}
             )
 
     def test_pipeline_with_invalid_parameter_args(self):
@@ -123,6 +125,8 @@ def test_pipeline_with_int_param(self):
                 {
                     "code": "test",
                     "name": "Test pipeline",
+                    "function": None,
+                    "tasks": [],
                     "parameters": [
                         {
                             "choices": None,
@@ -162,6 +166,8 @@ def test_pipeline_with_multiple_param(self):
                 {
                     "code": "test",
                     "name": "Test pipeline",
+                    "function": None,
+                    "tasks": [],
                     "parameters": [
                         {
                             "choices": None,
@@ -243,6 +249,8 @@ def test_pipeline_with_choices(self):
                 {
                     "code": "test",
                     "name": "Test pipeline",
+                    "function": None,
+                    "tasks": [],
                     "parameters": [
                         {
                             "choices": ["a", "b"],
@@ -277,8 +285,14 @@ def test_pipeline_with_timeout(self):
             pipeline = get_pipeline(tmpdirname)
             self.assertEqual(
                 pipeline.to_dict(),
-                {"code": "test", "function": None, "name": "Test pipeline", "parameters": [], "timeout": 42,
-                 "tasks": []}
+                {
+                    "code": "test",
+                    "name": "Test pipeline",
+                    "parameters": [],
+                    "timeout": 42,
+                    "function": None,
+                    "tasks": []
+                }
             )
 
     def test_pipeline_with_bool(self):
@@ -304,6 +318,8 @@ def test_pipeline_with_bool(self):
                 {
                     "code": "test",
                     "name": "Test pipeline",
+                    "function": None,
+                    "tasks": [],
                     "parameters": [
                         {
                             "choices": None,
@@ -344,6 +360,8 @@ def test_pipeline_with_multiple_parameters(self):
                 {
                     "code": "test",
                     "name": "Test pipeline",
+                    "function": None,
+                    "tasks" : [],
                     "parameters": [
                         {
                             "choices": None,